HDDS-3244. Improve write efficiency by opening RocksDB only once #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bharatviswa504 Could you help review this patch ? If you agree with the change, I will fix the CI failure. Thank you very much. |
mukul1987
reviewed
Mar 23, 2020
.../src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java
Show resolved
Hide resolved
runzhiwang
force-pushed
the
open-rocksdb-once
branch
3 times, most recently
from
b55237d
to
a145399
Compare
|
@bharatviswa504 Could you help review it again. |
bshashikant
reviewed
Apr 2, 2020
| ReferenceCountedDB db = | ||
| new ReferenceCountedDB(store, dbFile.getAbsolutePath()); | ||
| //add db handler into cache | ||
| BlockUtils.addDB(db, dbFile.getAbsolutePath(), conf); |
There was a problem hiding this comment.
I think its better to update the cache only at the end of function "createContainerMetaData" so that even if the chunk dir creation fails, it won't be added to the container cache.
bshashikant
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What's the problem ?
created in
HddsDispatcher.WriteChunk, but then the created RocksDB was closed, untilHddsDispatcher.PutBlockthe RocsDB will be opend again and then put it into cache, so the RocksDB was open twice in each datanode. Becase RocksDB.open cost about 200ms, so open it twice is a waste.How to fix it ?
HddsDispatcher.PutBlock.What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-3244
How was this patch tested?
Existed UT and IT.