Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3253. Initialize Recon metrics for prometheus at /prom endpoint #715

Closed
wants to merge 9 commits into from

Conversation

vivekratnavel
Copy link
Contributor

What changes were proposed in this pull request?

  • Initialize metrics for Recon at /prom endpoint

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3253

How was this patch tested?

  • By bringing up recon via docker-compose and testing /prom endpoint at recon (localhost:9888/prom)

@vivekratnavel
Copy link
Contributor Author

@avijayanhwx @elek Please review

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks the patch @vivekratnavel

Let's try to get a green build and will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants