HDDS-3074. Make the configuration of container scrub consistent. #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM +1 pending CI. |
|
Test failures are unrelated. |
|
Thank You @cku328 for the contribution. |
|
If you see a flaky test, please disable it (without and issue) + create a new open issue and repeat the build. There is some risk that one flakiness hides a other. Merging patches without green build makes harder to debug flaky tests. |
isahekmat
pushed a commit
to isahekmat/hadoop-ozone
that referenced
this pull request
Mar 29, 2020
|
Thanks @avijayanhwx & @bharatviswa504 for the review, and @elek for your advice on flaky test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When we set
hdds.container.scrub.enabled(in ozone-site.xml) to true, container scrub didn't work because the prefix of the configuration is incorrect, like this:So I fixed the prefix of the configuration (replace it with hdds.container.scrub), it did work.
What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-3074
How was this patch tested?
Check logs on Ozone Single Cluster.