Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3332. Upgrade Robot tests to Python 3 #766

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Upgrade Robot tests to Python 3 by using a newer ozone-runner image, which has Python 3 installed.

https://issues.apache.org/jira/browse/HDDS-3332

How was this patch tested?

CI: https://github.com/adoroszlai/hadoop-ozone/runs/558100142

Tested that runaway command is stopped after the specified timeout (10 seconds):

$ time docker run -it --rm -v $(pwd):/tmp apache/ozone-runner:20200403-1 robot /tmp/tmp.robot
To use Ozone please mount ozone folder to /opt/hadoop
==============================================================================
Tmp :: Timeout test
==============================================================================
Test timeout behavior with wait                                       | FAIL |
Test timeout 10 seconds exceeded.
------------------------------------------------------------------------------
Tmp :: Timeout test                                                   | FAIL |
1 critical test, 0 passed, 1 failed
1 test total, 0 passed, 1 failed
==============================================================================
Output:  /opt/hadoop/output.xml
Log:     /opt/hadoop/log.html
Report:  /opt/hadoop/report.html
docker run -it --rm -v $(pwd):/tmp apache/ozone-runner:20200403-1 robot   0.03s user 0.09s system 1% cpu 11.384 total

whereas previously it ran until completion (30 seconds):

$ time docker run -it --rm -v $(pwd):/tmp apache/ozone-runner:20191107-1 robot /tmp/tmp.robot
To use Ozone please mount ozone folder to /opt/hadoop
==============================================================================
Tmp :: Timeout test
==============================================================================
Test timeout behavior with wait                                       | FAIL |
Test timeout 10 seconds exceeded.
------------------------------------------------------------------------------
Tmp :: Timeout test                                                   | FAIL |
1 critical test, 0 passed, 1 failed
1 test total, 0 passed, 1 failed
==============================================================================
Output:  /opt/hadoop/output.xml
Log:     /opt/hadoop/log.html
Report:  /opt/hadoop/report.html
docker run -it --rm -v $(pwd):/tmp apache/ozone-runner:20191107-1 robot   0.03s user 0.07s system 0% cpu 31.267 total

@adoroszlai adoroszlai self-assigned this Apr 3, 2020
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to put this final piece in. I am +1 if CI agrees...

Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @adoroszlai for the improvement and @elek for the reviews.

@dineshchitlangia dineshchitlangia merged commit b4eafde into apache:master Apr 3, 2020
@adoroszlai adoroszlai deleted the HDDS-3332-runner branch April 3, 2020 18:31
@adoroszlai
Copy link
Contributor Author

Thanks @elek and @dineshchitlangia for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants