HDDS-3359. Remove Yetus helper code from Ozone. #787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elek
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
+1. Thanks to make it done, @mukul1987
Yetus is not used any more. It's confusing to have it here.
As you removed the comment in the cheks.sh which explains why we need $AUTHOR
#hide this string to not confuse yetus
I would remove the workaround (lines with AUTHOR), too, and use "@author" directly
grep -r --include="*.java" "@author" . | tee "$REPORT_FILE"
|
Thanks for the review @elek . I have changed the lines as suggested. |
elek
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Yetus related helper code is not currently being used. It can be removed from the repo.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3359
How was this patch tested?
A build after this change works correctly.