add build docs #110
Merged
add build docs #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Jul 18, 2023
pjfanning
commented
- basic build notes
- far from complete but possibly enough to tide over someone who just wants to basic build verification
|
@mdedetrich I added this in anticipation of an imminent RC |
He-Pin
approved these changes
Jul 23, 2023
|
|
||
| ### Running the Build | ||
| - Open a command window and change directory to your preferred base directory | ||
| - Use git to clone the [repo](https://github.com/apache/incubator-pekko-connectors-kafka) or download a source release from https://pekko.apache.org (and unzip or untar it, as appropriate) |
There was a problem hiding this comment.
Since the sentence already says Use git, I'm not sure it is a good idea to say git repo. I think most people would infer thet repo is a git repo. It doesn't read well read to repeat the same word multiple times in a sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.