Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates Cassandra driver #100

Merged
merged 1 commit into from May 11, 2023
Merged

updates Cassandra driver #100

merged 1 commit into from May 11, 2023

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented May 9, 2023

No description provided.

@nvollmar nvollmar mentioned this pull request May 9, 2023
Merged
@nvollmar nvollmar requested a review from mdedetrich May 9, 2023 05:42
@mdedetrich
Copy link
Contributor

I actually wanted to entertain the idea in general, i.e. updating all of the drivers in connectors to their latest respective versions, @pjfanning wdyt?

@nvollmar is 4.15.0 is fully compatible with 4.13.0?

@mdedetrich
Copy link
Contributor

mdedetrich commented May 9, 2023 •
edited

Ah I just got the context from apache/pekko-persistence-cassandra#35

@nvollmar
Copy link
Contributor Author

nvollmar commented May 9, 2023

We've been running with 4.14.1 and 4.15.0 without issues for a long time.
The changelog is here: https://github.com/datastax/java-driver/blob/4.x/changelog/README.md

mdedetrich
mdedetrich approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in apache/pekko-persistence-cassandra#35 (review) I will approve this PR but lets wait for a week before merging to see if @pjfanning has any objections

pjfanning
pjfanning approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich
Copy link
Contributor

mdedetrich commented May 11, 2023 •
edited

@pjfanning @nvollmar Shall I merge this PR so its included in the next snapshot that I will be pushing into all of the dependant projects?

That way we can kill 2 birds with one stone, i.e. apply these compat changes as well as update the cassandra driver version which can be used in apache/pekko-persistence-cassandra#35

@nvollmar
Copy link
Contributor Author

@mdedetrich 👍

@mdedetrich
Copy link
Contributor

Cool, ill wait to see if @pjfanning has any objections.

@pjfanning
Copy link
Contributor

it's ok to merge this

@mdedetrich mdedetrich merged commit a82f3c3 into main May 11, 2023
50 checks passed
@mdedetrich mdedetrich deleted the update-driver branch May 11, 2023 08:11
@pjfanning pjfanning added the release note should be mentioned in release notes label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning approved these changes

@mdedetrich mdedetrich mdedetrich approved these changes

Assignees
No one assigned
Labels
release note should be mentioned in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nvollmar @mdedetrich @pjfanning