-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds explicit driver version #35
Conversation
45e0bc1
to
c353437
Compare
@nvollmar @pjfanning Is this something that is slated for 1.0.0? |
@mdedetrich I'll update the PR, would find it beneficial to update the driver |
Also created a PR in pekko-connectors to keep them in sync: apache/pekko-connectors#100 We've overridden the driver version of persistence-cassandra for a long time to get some critical bug fixes. Akka also upgraded to 1.14.1 meanwhile. The biggest change in 1.15.0 was CodecNotFoundException now extending DriverException, otherwise just small improvements and doc changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I am assuming that if the bugs in the newest Cassandra where critical enough that you were forced to update the version it makes sense to approve/merge this.
I will approve the PR, but I will wait for a week for a response from @pjfanning before merging.
With the upgrade we worked around a bug in akka-persistence-cassandra, which we meanwhile have also fixed directly (Rolling Cassandra caused Akka to lose prepared statements and breaking persistence forcing a restart of Akka nodes to fix). But the driver has other bugfixes and improvements that are beneficial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.