Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds explicit driver version #35

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

nvollmar
Copy link
Contributor

No description provided.

@nvollmar nvollmar marked this pull request as draft March 22, 2023 09:07
@nvollmar nvollmar force-pushed the update-driver branch 5 times, most recently from 45e0bc1 to c353437 Compare March 22, 2023 12:26
@mdedetrich
Copy link
Contributor

@nvollmar @pjfanning Is this something that is slated for 1.0.0?

@nvollmar
Copy link
Contributor Author

nvollmar commented May 9, 2023

@mdedetrich I'll update the PR, would find it beneficial to update the driver

@nvollmar nvollmar marked this pull request as ready for review May 9, 2023 05:08
@nvollmar
Copy link
Contributor Author

nvollmar commented May 9, 2023

Also created a PR in pekko-connectors to keep them in sync: apache/pekko-connectors#100

We've overridden the driver version of persistence-cassandra for a long time to get some critical bug fixes. Akka also upgraded to 1.14.1 meanwhile. The biggest change in 1.15.0 was CodecNotFoundException now extending DriverException, otherwise just small improvements and doc changes.

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I am assuming that if the bugs in the newest Cassandra where critical enough that you were forced to update the version it makes sense to approve/merge this.

I will approve the PR, but I will wait for a week for a response from @pjfanning before merging.

@nvollmar
Copy link
Contributor Author

nvollmar commented May 9, 2023

With the upgrade we worked around a bug in akka-persistence-cassandra, which we meanwhile have also fixed directly (Rolling Cassandra caused Akka to lose prepared statements and breaking persistence forcing a restart of Akka nodes to fix).

But the driver has other bugfixes and improvements that are beneficial.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nvollmar nvollmar merged commit c30f82a into apache:main May 11, 2023
8 checks passed
@nvollmar nvollmar deleted the update-driver branch May 11, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants