Update naming for status codes 413 and 422

[Philippus]

I think the naming changed in RFC 9110, see https://www.rfc-editor.org/rfc/rfc9110.html#name-413-content-too-large and https://www.rfc-editor.org/rfc/rfc9110.html#name-422-unprocessable-content.

[pjfanning]

Are there any tests maintained for the legacy status codes? We need to prove that users can still respond with old status code variant.

[jrudolph]

Nice addition, thanks @Philippus.

Is that something we would consider for 1.0.0? There's little risk but currently I'd say let's postpone to 1.1.x on principle since it is not strictly necessary right now?

[mdedetrich]

Is that something we would consider for 1.0.0? There's little risk but currently I'd say let's postpone to 1.1.x on principle since it is not strictly necessary right now?

Agreed, milestone set

[mdedetrich]

@Philippus Apologies but my javafmt commit caused some merge conflicts on this PR but they are relatively minor. If you do a rebase on origin/main and run sbt javafmt it should remove the conflicts.

Let me know if you have time/are able to do this, otherwise I can just fix it up before merging the PR.

[pjfanning]

there is no hurry on this as we are unlikely to include this in the pekko-http 1.0.0 release (and add it later instead)

[mdedetrich]

Indeed take your time, its not urgent

[Philippus]

I'll fix it up once the first pekko-http is out of the door.

[He-Pin]

@Philippus You need rebase your PR.

[pjfanning]

lgtm

[jrudolph]

lgtm

[pjfanning]

Apologies - I was going around approving PRs but I forgot about the Scala 3 compile issue in this PR - hopefully, we;ll get around to fixing that soon

[mdedetrich]

Was about to say that the tests are failing with java.lang.NoClassDefFoundError: Could not initialize class org.apache.pekko.http.scaladsl.model.StatusCodes$

[jrudolph]

Are there any tests maintained for the legacy status codes? We need to prove that users can still respond with old status code variant.

This is only an API change and for those changes we mostly rely on Mima to catch problems. We also have the (currently disabled) "http-compatibility-tests" module which has logic to test backward compatibility in cases which warrant more testing.

[jrudolph]

Needs the below fixes to fix the runtime errors.

[pjfanning]

this should be since 1.1.0 - 1.0.0 was released without this change

[jrudolph]

👍 good point

[jrudolph]

(btw. test error is likely unrelated)

[He-Pin]

lgtm

[pjfanning]

lgtm

[jrudolph]

Thanks again, @Philippus!