-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding gRPC Kubernetes sample #75
Conversation
|
||
"org.apache.pekko" %% "pekko-discovery-kubernetes-api" % discoveryVersion, | ||
|
||
"ch.qos.logback" % "logback-classic" % "1.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use 1.2.10 or something newer?
<appender-ref ref="ASYNC"/> | ||
</root> | ||
|
||
</configuration> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a new line at end of file?
|
||
"org.apache.pekko" %% "pekko-http" % pekkoHttpVersion, | ||
|
||
"ch.qos.logback" % "logback-classic" % "1.4.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we stick with logback 1.2.x - just a new version of 1.2.x? 1.4 requires Java 11 or something like that
Thanks - merged |
Related to apache/pekko-grpc#58:
test.sh
script provided in the sample.