Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove the deprecation of statefulMapConcat operator. #1147

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Feb 25, 2024

Motivation:
As reported in refs:#1141 , the current statefulMap will introduce some overhead from the allocation of tuple (State, Out). So let's just keep it before we come up with an allocation free version like JDK 22's gather api.

Result:
Remove the deprecation of statefulMapConcat.

Will need backport to 1.0.x branch.

Ping @JD557

@He-Pin He-Pin added this to the 1.1.0-M1 milestone Feb 25, 2024
@He-Pin He-Pin added the t:stream Pekko Streams label Feb 25, 2024
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@He-Pin
Copy link
Member Author

He-Pin commented Feb 27, 2024

@pjfanning PTAL, I will backport this once get merged.

@laglangyue
Copy link
Contributor

LGTM

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I think the warning change is ok

@He-Pin He-Pin merged commit c8a99aa into apache:main Feb 29, 2024
18 checks passed
@He-Pin He-Pin deleted the removeDeprecate branch February 29, 2024 05:11
He-Pin added a commit to He-Pin/incubator-pekko that referenced this pull request Feb 29, 2024
He-Pin added a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:stream Pekko Streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants