Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-6292 : Extend explain plan object based comparison to majority possible end2end tests #1049

Closed
wants to merge 1 commit into from
Closed

PHOENIX-6292 : Extend explain plan object based comparison to majority possible end2end tests #1049

wants to merge 1 commit into from

Conversation

virajjasani
Copy link
Contributor

No description provided.

@virajjasani virajjasani mentioned this pull request Jan 2, 2021
Closed
@stoty
Copy link
Contributor

stoty commented Jan 2, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 1s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 37s master passed
+1 💚 compile 0m 57s master passed
+1 💚 checkstyle 0m 28s master passed
+1 💚 javadoc 0m 45s master passed
+0 🆗 spotbugs 2m 54s phoenix-core in master has 973 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 7m 33s the patch passed
+1 💚 compile 0m 54s the patch passed
+1 💚 javac 0m 54s the patch passed
+1 💚 checkstyle 0m 26s the patch passed
-1 ❌ whitespace 0m 0s The patch 2 line(s) with tabs.
+1 💚 javadoc 0m 46s the patch passed
+1 💚 spotbugs 3m 8s the patch passed
_ Other Tests _
-1 ❌ unit 108m 9s phoenix-core in the patch failed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
150m 5s
Reason Tests
Failed junit tests phoenix.end2end.index.IndexMetadataIT
phoenix.end2end.InListIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1049
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 429e9879f8c9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / e7264df
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/1/artifact/yetus-general-check/output/whitespace-tabs.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/1/testReport/
Max. process+thread count 6711 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jan 2, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 14m 27s master passed
+1 💚 compile 0m 54s master passed
+1 💚 checkstyle 0m 26s master passed
+1 💚 javadoc 0m 45s master passed
+0 🆗 spotbugs 2m 55s phoenix-core in master has 973 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 7m 27s the patch passed
+1 💚 compile 0m 53s the patch passed
+1 💚 javac 0m 53s the patch passed
+1 💚 checkstyle 0m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 45s the patch passed
+1 💚 spotbugs 3m 7s the patch passed
_ Other Tests _
-1 ❌ unit 111m 39s phoenix-core in the patch failed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
147m 40s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1049
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 2539d966d2cc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / e7264df
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/2/testReport/
Max. process+thread count 6772 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jan 2, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 14m 22s master passed
+1 💚 compile 0m 55s master passed
+1 💚 checkstyle 0m 27s master passed
+1 💚 javadoc 0m 46s master passed
+0 🆗 spotbugs 2m 58s phoenix-core in master has 973 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 7m 40s the patch passed
+1 💚 compile 0m 52s the patch passed
+1 💚 javac 0m 52s the patch passed
+1 💚 checkstyle 0m 27s the patch passed
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+1 💚 javadoc 0m 43s the patch passed
+1 💚 spotbugs 3m 2s the patch passed
_ Other Tests _
-1 ❌ unit 109m 20s phoenix-core in the patch failed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
145m 25s
Reason Tests
Failed junit tests phoenix.end2end.index.IndexMetadataIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1049
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux e4ec141bf59a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / e7264df
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/3/testReport/
Max. process+thread count 6360 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/3/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jan 3, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 16m 8s master passed
+1 💚 compile 0m 59s master passed
+1 💚 checkstyle 0m 27s master passed
+1 💚 javadoc 0m 48s master passed
+0 🆗 spotbugs 3m 12s phoenix-core in master has 973 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 9m 25s the patch passed
+1 💚 compile 1m 15s the patch passed
+1 💚 javac 1m 15s the patch passed
+1 💚 checkstyle 0m 35s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 56s the patch passed
+1 💚 spotbugs 3m 51s the patch passed
_ Other Tests _
-1 ❌ unit 186m 11s phoenix-core in the patch failed.
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
228m 13s
Reason Tests
Failed junit tests phoenix.tx.TransactionIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1049
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 58d67aeed767 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / e7264df
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/4/testReport/
Max. process+thread count 5874 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1049/4/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty
stoty approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty stoty closed this Jan 4, 2021
@virajjasani virajjasani deleted the PHOENIX-6292-master branch January 4, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoty stoty stoty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@virajjasani @stoty