Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6292 : Extend explain plan object based comparison to majority possible end2end tests #1050

Closed
wants to merge 1 commit into from
Closed

Conversation

virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Jan 2, 2021

4.x backport of PR #1049

@stoty
Copy link
Contributor

stoty commented Jan 2, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 13m 20s 4.x passed
+1 💚 compile 1m 0s 4.x passed
+1 💚 checkstyle 0m 27s 4.x passed
+1 💚 javadoc 0m 47s 4.x passed
+0 🆗 spotbugs 2m 56s phoenix-core in 4.x has 962 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 42s the patch passed
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
+1 💚 checkstyle 0m 27s the patch passed
-1 ❌ whitespace 0m 0s The patch 2 line(s) with tabs.
+1 💚 javadoc 0m 44s the patch passed
+1 💚 spotbugs 3m 14s the patch passed
_ Other Tests _
-1 ❌ unit 128m 14s phoenix-core in the patch failed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
162m 3s
Reason Tests
Failed junit tests phoenix.end2end.index.MutableIndexIT
phoenix.end2end.InListIT
phoenix.end2end.index.PartialIndexRebuilderIT
phoenix.end2end.join.SortMergeJoinGlobalIndexIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1050
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 669aa6b46afb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / dfbdeac
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/1/artifact/yetus-general-check/output/whitespace-tabs.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/1/testReport/
Max. process+thread count 5973 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jan 2, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 13m 0s 4.x passed
+1 💚 compile 0m 59s 4.x passed
+1 💚 checkstyle 0m 25s 4.x passed
+1 💚 javadoc 0m 45s 4.x passed
+0 🆗 spotbugs 3m 4s phoenix-core in 4.x has 962 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 49s the patch passed
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
+1 💚 checkstyle 0m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 43s the patch passed
+1 💚 spotbugs 3m 11s the patch passed
_ Other Tests _
+1 💚 unit 131m 9s phoenix-core in the patch passed.
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
162m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1050
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux c550a8da4ebc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / dfbdeac
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/2/testReport/
Max. process+thread count 6129 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jan 2, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 13m 8s 4.x passed
+1 💚 compile 1m 1s 4.x passed
+1 💚 checkstyle 0m 26s 4.x passed
+1 💚 javadoc 0m 46s 4.x passed
+0 🆗 spotbugs 2m 59s phoenix-core in 4.x has 962 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 44s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 checkstyle 0m 25s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 45s the patch passed
+1 💚 spotbugs 3m 8s the patch passed
_ Other Tests _
+1 💚 unit 131m 50s phoenix-core in the patch passed.
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
162m 58s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1050
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 25978c5e46b6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / dfbdeac
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/3/testReport/
Max. process+thread count 6172 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/3/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jan 3, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 13m 7s 4.x passed
+1 💚 compile 1m 2s 4.x passed
+1 💚 checkstyle 0m 27s 4.x passed
+1 💚 javadoc 0m 44s 4.x passed
+0 🆗 spotbugs 2m 58s phoenix-core in 4.x has 962 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 41s the patch passed
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
+1 💚 checkstyle 0m 26s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 43s the patch passed
+1 💚 spotbugs 3m 9s the patch passed
_ Other Tests _
+1 💚 unit 131m 16s phoenix-core in the patch passed.
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
167m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1050
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 7e05d758d70d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / dfbdeac
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/4/testReport/
Max. process+thread count 6015 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1050/4/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty stoty closed this Jan 4, 2021
@virajjasani virajjasani deleted the PHOENIX-6292-4.x branch January 4, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants