Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-3710 Cannot use lowername data table name with indextool #1076

Closed
wants to merge 1 commit into from
Closed

PHOENIX-3710 Cannot use lowername data table name with indextool #1076

wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Jan 7, 2021

Co-authored-by: Ankit Singhal ankitsinghal59@gmail.com
Co-authored-by: Josh Elser elserj@apache.org

@stoty
Copy link
Contributor Author

stoty commented Jan 7, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 13m 44s 4.x passed
+1 💚 compile 1m 1s 4.x passed
+1 💚 checkstyle 0m 59s 4.x passed
+1 💚 javadoc 0m 45s 4.x passed
+0 🆗 spotbugs 2m 53s phoenix-core in 4.x has 961 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 43s the patch passed
+1 💚 compile 0m 59s the patch passed
+1 💚 javac 0m 59s the patch passed
-1 ❌ checkstyle 1m 0s phoenix-core: The patch generated 40 new + 1292 unchanged - 31 fixed = 1332 total (was 1323)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 45s the patch passed
+1 💚 spotbugs 3m 7s the patch passed
_ Other Tests _
-1 ❌ unit 133m 8s phoenix-core in the patch failed.
-1 ❌ asflicense 0m 50s The patch generated 1 ASF License warnings.
173m 19s
Reason Tests
Failed junit tests phoenix.end2end.IndexToolIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1076
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 5d370d4e7004 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 43b56d4
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 5902 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@joshelser
Copy link
Member 

[ERROR] Tests run: 75, Failures: 0, Errors: 15, Skipped: 0, Time elapsed: 371.697 s <<< FAILURE! - in org.apache.phoenix.end2end.IndexToolIT
[ERROR] testCaseSensitiveNames[transactionProvider=TEPHRA,mutable=false,localIndex=false,directApi=true,useSnapshot=false,useTenant=false](org.apache.phoenix.end2end.IndexToolIT)  Time elapsed: 16.924 s  <<< ERROR!
java.lang.NullPointerException
	at org.apache.phoenix.end2end.IndexToolIT.verifyMapper(IndexToolIT.java:931)
	at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:973)
	at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:953)
	at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:944)
	at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:938)
	at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:911)
	at org.apache.phoenix.end2end.IndexToolIT.testCaseSensitiveNames(IndexToolIT.java:743)

Looks like a valid test failure.

@stoty
Copy link
Contributor Author

stoty commented Jan 8, 2021

Looks like a valid test failure.

I always falsely hope that the backport won't introduce problems. Sorry for not noticing this before pinging you.

@stoty @ankitsinghal @joshelser
PHOENIX-3710 Cannot use lowername data table name with indextool
5f0e253 
Co-authored-by: Ankit Singhal <ankitsinghal59@gmail.com>
Co-authored-by: Josh Elser <elserj@apache.org>
@stoty
Copy link
Contributor Author

stoty commented Jan 12, 2021

Updated commons-cli to 1.4 (as in master)
changed parser implementation (to be the same as in master)

@stoty
Copy link
Contributor Author

stoty commented Jan 12, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+0 🆗 mvndep 4m 30s Maven dependency ordering for branch
+1 💚 mvninstall 9m 41s 4.x passed
+1 💚 compile 1m 31s 4.x passed
+1 💚 checkstyle 1m 3s 4.x passed
+1 💚 javadoc 1m 54s 4.x passed
+0 🆗 spotbugs 4m 12s root in 4.x has 999 extant spotbugs warnings.
+0 🆗 spotbugs 2m 47s phoenix-core in 4.x has 945 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 5m 49s the patch passed
+1 💚 compile 1m 31s the patch passed
+1 💚 javac 1m 31s the patch passed
-1 ❌ checkstyle 1m 4s root: The patch generated 43 new + 1308 unchanged - 34 fixed = 1351 total (was 1342)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 57s the patch passed
+1 💚 spotbugs 7m 33s the patch passed
_ Other Tests _
-1 ❌ unit 147m 25s root in the patch failed.
+1 💚 asflicense 0m 23s The patch does not generate ASF License warnings.
193m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1076
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml
uname Linux 70d03b943ea9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / f1df239
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/testReport/
Max. process+thread count 5743 (vs. ulimit of 30000)
modules C: phoenix-core . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor Author

stoty commented Jan 12, 2021

Can you check this again @joshelser ?
The tests are clean.
The shading failures are an unrealted issue.

@stoty stoty requested a review from joshelser January 12, 2021 13:26
@stoty stoty closed this Jan 14, 2021
joshelser
joshelser reviewed Jan 17, 2021
View reviewed changes
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was also too slow here. +1

@stoty stoty deleted the PHOENIX-3710-4.x branch July 29, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshelser joshelser joshelser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoty @joshelser