New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-6309 : Use maven enforcer plugin to ban imports from illegal packages (as per project guidelines) #1082
Conversation
💔 -1 overall
This message was automatically generated. |
LGTM +1 for the master branch. However, do we have a plan to do the same thing for the 4.x? I remember that we don't have enforcement for certain important. For example, we have |
Thanks @yanxinyi for the review.
@stoty has already created PHOENIX-6234 for replacing guava with thirdparty in 4.x. |
On master, this is somewhat redundant, as dependency-check will fail the build in these cases. However, as dependency-check runs AFTER the tests, and the tests still fail more oftent than not, this may be useful if this runs before the tests, (and on 4.x.) The commons-logging and commons-lang stuff definitely applies to 4.x |
Yes, it does catch this before running tests. |
Does 4.x still have commons-lang ? That is probably a regression, and you may want to fix it in #1083 and add the rule. |
4.x has many references to commons-lang. Let me fix them and update #1083 quickly. |
In that it probably not a regression, I just never got around to backporting that cleanup to 4.x I'll leave it to your discretion wheter you want to that for this ticket. |
On master, commons-lang was upgraded as part of PHOENIX-4880 |
Sounds good. (good to know it wasn't me who skipped the 4.x backport) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version for the rule seems to be 1.0.1
Is there any reason to use an older version?
My bad, in fact we can use 1.1.0 instead. |
While copying from other project, I somehow missed looking at latest versions. Let me update PR. |
Attaching sample build failure:
|
…packages (as per project guidelines)
💔 -1 overall
This message was automatically generated. |
No description provided.