PHOENIX-1674 Snapshot isolation transaction support through Tephra #129
Conversation
| // recreate index table | ||
| admin.createTable(indexTableDesc); | ||
| do { | ||
| Thread.sleep(15 * 1000); // sleep 15 secs |
There was a problem hiding this comment.
How is this sleep helping? Is it account for the async nature of the API? FWIW, the admin.createTable() already retries before it throws TableNotFoundException. If the number of retries is too small then you could possibly increasing the number of retries too.
There was a problem hiding this comment.
After we re-create the index htable, we wait till the index become ACTIVE again, not sure what process is responsible for enable/disabling the index state.
There was a problem hiding this comment.
This sleep was already there, though, right?
|
I can't find PhoenixTransactionalIndexer. Did your latest pull forget to add new files? Or maybe I'm just missing it? FYI, I remember there are a few bits of commented out code that should be removed from that file. Everything else looks good to me - except for a few minor comments above. |
| userName = connInfo.getPrincipal(); | ||
| metaData = newEmptyMetaData(); | ||
|
|
||
| // Use KeyValueBuilder that builds real KeyValues, as our test utils require this | ||
| this.kvBuilder = GenericKeyValueBuilder.INSTANCE; | ||
| // TOOD: copy/paste from ConnectionQueryServicesImpl |
@JamesRTaylor @samarthjain
PR will code review feedback.