Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner #1130

Closed
wants to merge 1 commit into from

Conversation

tkhurana
Copy link
Contributor

@tkhurana tkhurana commented Feb 4, 2021

If PagedScanFilter is set on the scan, a dummy row can be returned which needs to be skipped.

…anner

If PagedScanFilter is set on the scan, a dummy row can be returned
which needs to be skipped.
@tkhurana
Copy link
Contributor Author

tkhurana commented Feb 4, 2021

@stoty @kadirozde

Copy link
Contributor

@kadirozde kadirozde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, Thanks

@stoty
Copy link
Contributor

stoty commented Feb 4, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 15m 24s 4.x passed
+1 💚 compile 1m 4s 4.x passed
+1 💚 checkstyle 0m 38s 4.x passed
+1 💚 javadoc 0m 47s 4.x passed
+0 🆗 spotbugs 3m 18s phoenix-core in 4.x has 945 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 6m 52s the patch passed
+1 💚 compile 1m 6s the patch passed
+1 💚 javac 1m 6s the patch passed
-1 ❌ checkstyle 0m 37s phoenix-core: The patch generated 6 new + 630 unchanged - 6 fixed = 636 total (was 636)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 47s the patch passed
+1 💚 spotbugs 3m 29s the patch passed
_ Other Tests _
-1 ❌ unit 180m 28s phoenix-core in the patch failed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
223m 22s
Reason Tests
Failed junit tests phoenix.end2end.index.PartialIndexRebuilderIT
phoenix.end2end.MapReduceIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1130
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 497fd7b7fa1c 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 4bd1ec5
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/testReport/
Max. process+thread count 4997 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1130/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tkhurana
Copy link
Contributor Author

tkhurana commented Feb 4, 2021

@stoty @kadirozde can someone merge this. The 2 tests that failed have been passing locally

@stoty stoty closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants