Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use … #1242

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

richardantal
Copy link
Contributor

…it in sqlline.py

Change-Id: Ifd31e25b303ab3d2872b53f4a503219539777544

@stoty
Copy link
Contributor

stoty commented May 31, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+0 🆗 mvndep 5m 30s Maven dependency ordering for branch
+1 💚 mvninstall 10m 52s 4.x passed
+1 💚 compile 2m 4s 4.x passed
+1 💚 javadoc 1m 59s 4.x passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
-1 ❌ mvninstall 7m 29s root in the patch failed.
-1 ❌ compile 2m 6s root in the patch failed.
-1 ❌ javac 2m 6s root in the patch failed.
-1 ❌ pylint 0m 11s The patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 10s The patch has no ill-formed XML file.
-1 ❌ javadoc 1m 36s root in the patch failed.
-1 ❌ javadoc 0m 12s phoenix-assembly in the patch failed.
_ Other Tests _
-1 ❌ unit 161m 1s root in the patch failed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
200m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1242
Optional Tests dupname asflicense pylint javac javadoc unit xml compile
uname Linux 6c8f872f3f2f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / d0c5627
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-compile-root.txt
pylint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/diff-patch-pylint.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-javadoc-root.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/testReport/
Max. process+thread count 5503 (vs. ulimit of 30000)
modules C: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/console
versions git=2.7.4 maven=3.3.9 pylint=2.4.4
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…it in sqlline.py

Change-Id: Ifd31e25b303ab3d2872b53f4a503219539777544
@stoty
Copy link
Contributor

stoty commented May 31, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+0 🆗 mvndep 5m 11s Maven dependency ordering for branch
+1 💚 mvninstall 9m 17s 4.x passed
+1 💚 compile 1m 32s 4.x passed
+1 💚 javadoc 1m 31s 4.x passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
-1 ❌ mvninstall 5m 36s root in the patch failed.
-1 ❌ compile 1m 27s root in the patch failed.
-1 ❌ javac 1m 27s root in the patch failed.
-1 ❌ pylint 0m 8s The patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 8s The patch has no ill-formed XML file.
-1 ❌ javadoc 1m 10s root in the patch failed.
-1 ❌ javadoc 0m 9s phoenix-assembly in the patch failed.
_ Other Tests _
-1 ❌ unit 153m 16s root in the patch failed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
182m 0s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1242
Optional Tests dupname asflicense pylint javac javadoc unit xml compile
uname Linux cf582dff551e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / d0c5627
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-compile-root.txt
pylint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/diff-patch-pylint.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-javadoc-root.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/testReport/
Max. process+thread count 5683 (vs. ulimit of 30000)
modules C: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/console
versions git=2.7.4 maven=3.3.9 pylint=2.4.4
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented May 31, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+0 🆗 mvndep 5m 20s Maven dependency ordering for branch
+1 💚 mvninstall 11m 25s 4.x passed
+1 💚 compile 2m 4s 4.x passed
+1 💚 javadoc 1m 50s 4.x passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
-1 ❌ mvninstall 8m 5s root in the patch failed.
-1 ❌ compile 1m 57s root in the patch failed.
-1 ❌ javac 1m 57s root in the patch failed.
-1 ❌ pylint 0m 11s The patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 10s The patch has no ill-formed XML file.
-1 ❌ javadoc 1m 29s root in the patch failed.
-1 ❌ javadoc 0m 11s phoenix-assembly in the patch failed.
_ Other Tests _
-1 ❌ unit 171m 46s root in the patch failed.
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
207m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1242
Optional Tests dupname asflicense pylint javac javadoc unit xml compile
uname Linux dd69f7c82397 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / d0c5627
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-compile-root.txt
pylint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/diff-patch-pylint.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-javadoc-root.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/testReport/
Max. process+thread count 5871 (vs. ulimit of 30000)
modules C: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/console
versions git=2.7.4 maven=3.3.9 pylint=2.4.4
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@richardantal
Copy link
Contributor Author

Built it locally and run a smoke test with sqlline.py

@richardantal richardantal requested a review from stoty June 7, 2021 14:27
@richardantal richardantal merged commit eb8a91e into apache:4.x Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants