-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-4555 Only mark view as updatable if rows cannot overlap with other updatable views #1704
base: master
Are you sure you want to change the base?
Conversation
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java
Outdated
Show resolved
Hide resolved
…other updatable views
…ssQueryServices used
…ectionlessQueryServices used" This reverts commit d82f36f.
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1704/9/artifact/yetus-general-check/output/results-asflicense.txt |
you can refer to 2e0da18 Basically we need to handle namespace resolution. |
The above commit belongs to PR #1709 |
Let me keep this here for reference, we can also contribute this later as separate commit. Patch to run BackwardCompatibilityIT locally:
|
We are really close now :) |
For the failed test org.apache.phoenix.end2end.index.ChildViewsUseParentViewIndexIT.testParentViewIndexWithSpecializedChildViews, seems it's an existing bug on view indexes because I ran the modified test on master branch and got the same issue. @jpisaac also got this issue on another test when views extending pk, and now it also happens on views without extending pk. Maybe we can create a Jira for this bug and ignore this test for now. |
Jira: PHOENIX-4555