-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-7067 View indexes should be created only on non overlapping updatable views #1709
Conversation
// for view indexes | ||
if (dataTable.getType() == PTableType.VIEW) { | ||
String physicalName = dataTable.getPhysicalName().getString(); | ||
physicalSchemaName = SchemaUtil.getSchemaNameFromFullName(physicalName); | ||
physicalTableName = SchemaUtil.getTableNameFromFullName(physicalName); | ||
List<ColumnName> requiredCols = Lists.newArrayList(indexedColumnNames); | ||
verifyIfDescViewsExtendPk(dataTable, config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: method name, can get confused with Descending order. Maybe use full verb verifyIfDescendantViewsExtendsPk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1, one nit
This reverts commit 1cfd25d.
|
Jira: PHOENIX-7067