PHOENIX-5456 IndexScrutinyTool slow for indexes on multitenant tables… #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpoon
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
The change lgtm.
Btw, is there a way for us to run a scrutiny on multitenant view index, for all tenants?
I'm wondering if we one day get PHOENIX-4657, does this change make such a scrutiny not possible?
| PTable pDataTable = pconn.getTable(new PTableKey(null, multiTenantTable)); | ||
| PTable pIndexTable = pconn.getTable(new PTableKey(null, indexNameGlobal)); | ||
|
|
||
| //IndexColumnNames columnNames = new IndexColumnNames(pDataTable, pIndexTable); |
| @Parameterized.Parameters public static Collection<Object[]> data() { | ||
| return Arrays.asList(new Object[][] { { "CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR, ZIP INTEGER, EMPLOY_DATE TIMESTAMP, EMPLOYER VARCHAR)", | ||
| "CREATE LOCAL INDEX %s ON %s (NAME, EMPLOY_DATE) INCLUDE (ZIP)" }, { "CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR, ZIP INTEGER, EMPLOY_DATE TIMESTAMP, EMPLOYER VARCHAR) SALT_BUCKETS=2", | ||
| "CREATE INDEX %s ON %s (NAME, EMPLOY_DATE) INCLUDE (ZIP)" }, { "CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR, ZIP INTEGER, EMPLOY_DATE TIMESTAMP, EMPLOYER VARCHAR) SALT_BUCKETS=2", |
There was a problem hiding this comment.
I think we should be able to add "MULTI_TENANT=TRUE" without anything failing. But I guess "testColumnsForSelectQueryOnMultiTenantTable" in the other class already tests what we want.
There was a problem hiding this comment.
yeah, the multitenant_tenant = true ones are in the other file
|
LGTM. Thanks |
… and IndexScrutinyIT doesn't run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and IndexScrutinyIT doesn't run