Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-5456 IndexScrutinyTool slow for indexes on multitenant tables… #575

Closed
wants to merge 1 commit into from
Closed

PHOENIX-5456 IndexScrutinyTool slow for indexes on multitenant tables… #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 137 additions & 0 deletions phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexScrutinyToolBaseIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more contributor license
* agreements. See the NOTICE file distributed with this work for additional information regarding
* copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the License. You may obtain a
* copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable
* law or agreed to in writing, software distributed under the License is distributed on an "AS IS"
* BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License
* for the specific language governing permissions and limitations under the License.
*/
package org.apache.phoenix.end2end;

import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.mapreduce.Counters;
import org.apache.hadoop.mapreduce.Job;
import org.apache.phoenix.mapreduce.index.IndexScrutinyTool;
import org.apache.phoenix.mapreduce.index.IndexScrutinyTool.OutputFormat;
import org.apache.phoenix.mapreduce.index.IndexScrutinyTool.SourceTable;
import org.apache.phoenix.mapreduce.index.PhoenixScrutinyJobCounters;
import org.apache.phoenix.query.BaseTest;
import org.apache.phoenix.query.QueryServices;
import org.apache.phoenix.util.ReadOnlyProps;
import org.junit.BeforeClass;

import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.List;
import java.util.Map;
import java.util.UUID;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

/**
* Tests for the {@link IndexScrutinyTool}
*/
public class IndexScrutinyToolBaseIT extends BaseTest {
protected String outputDir;

@BeforeClass public static void doSetup() throws Exception {
Map<String, String> serverProps = Maps.newHashMap();
//disable major compactions
serverProps.put(HConstants.MAJOR_COMPACTION_PERIOD, "0");
Map<String, String> clientProps = Maps.newHashMap();

clientProps.put(QueryServices.INDEX_REGION_OBSERVER_ENABLED_ATTRIB, Boolean.FALSE.toString());

setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()),
new ReadOnlyProps(clientProps.entrySet().iterator()));
}

protected List<Job> runScrutiny(String[] cmdArgs) throws Exception {
IndexScrutinyTool scrutiny = new IndexScrutinyTool();
Configuration conf = new Configuration(getUtility().getConfiguration());
scrutiny.setConf(conf);
int status = scrutiny.run(cmdArgs);
assertEquals(0, status);
for (Job job : scrutiny.getJobs()) {
assertTrue(job.waitForCompletion(true));
}
return scrutiny.getJobs();
}

protected String[] getArgValues(String schemaName, String dataTable, String indxTable, Long batchSize,
SourceTable sourceTable, boolean outputInvalidRows, OutputFormat outputFormat, Long maxOutputRows, String tenantId, Long scrutinyTs) {
final List<String> args = Lists.newArrayList();
if (schemaName != null) {
args.add("-s");
args.add(schemaName);
}
args.add("-dt");
args.add(dataTable);
args.add("-it");
args.add(indxTable);

// TODO test snapshot reads
// if(useSnapshot) {
// args.add("-snap");
// }

if (OutputFormat.FILE.equals(outputFormat)) {
args.add("-op");
outputDir = "/tmp/" + UUID.randomUUID().toString();
args.add(outputDir);
}

args.add("-t");
args.add(String.valueOf(scrutinyTs));
args.add("-run-foreground");
if (batchSize != null) {
args.add("-b");
args.add(String.valueOf(batchSize));
}

// default to using data table as the source table
args.add("-src");
if (sourceTable == null) {
args.add(SourceTable.DATA_TABLE_SOURCE.name());
} else {
args.add(sourceTable.name());
}
if (outputInvalidRows) {
args.add("-o");
}
if (outputFormat != null) {
args.add("-of");
args.add(outputFormat.name());
}
if (maxOutputRows != null) {
args.add("-om");
args.add(maxOutputRows.toString());
}
if (tenantId != null) {
args.add("-tenant");
args.add(tenantId);
}
return args.toArray(new String[0]);
}

protected long getCounterValue(Counters counters, Enum<PhoenixScrutinyJobCounters> counter) {
return counters.findCounter(counter).getValue();
}

protected int countRows(Connection conn, String tableFullName) throws SQLException {
ResultSet count = conn.createStatement().executeQuery("select count(*) from " + tableFullName);
count.next();
int numRows = count.getInt(1);
return numRows;
}

}


258 changes: 258 additions & 0 deletions phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexScrutinyToolForTenantIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,258 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more contributor license
* agreements. See the NOTICE file distributed with this work for additional information regarding
* copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the License. You may obtain a
* copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable
* law or agreed to in writing, software distributed under the License is distributed on an "AS IS"
* BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License
* for the specific language governing permissions and limitations under the License.
*/
package org.apache.phoenix.end2end;

import com.google.common.base.Joiner;
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.client.Admin;
import org.apache.hadoop.mapreduce.Counters;
import org.apache.hadoop.mapreduce.Job;
import org.apache.phoenix.jdbc.PhoenixConnection;
import org.apache.phoenix.mapreduce.index.IndexScrutinyTool;
import org.apache.phoenix.mapreduce.index.IndexScrutinyTool.OutputFormat;
import org.apache.phoenix.mapreduce.index.IndexScrutinyTool.SourceTable;
import org.apache.phoenix.mapreduce.index.SourceTargetColumnNames;
import org.apache.phoenix.parse.HintNode;
import org.apache.phoenix.query.ConnectionQueryServices;
import org.apache.phoenix.schema.PTable;
import org.apache.phoenix.schema.PTableKey;
import org.apache.phoenix.util.EnvironmentEdgeManager;
import org.apache.phoenix.util.PhoenixRuntime;
import org.apache.phoenix.util.PropertiesUtil;
import org.apache.phoenix.util.QueryUtil;
import org.apache.phoenix.util.SchemaUtil;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.experimental.categories.Category;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.SQLException;
import java.util.List;
import java.util.Properties;

import static org.apache.phoenix.mapreduce.index.IndexScrutinyTableOutput.OUTPUT_TABLE_NAME;
import static org.apache.phoenix.mapreduce.index.PhoenixScrutinyJobCounters.INVALID_ROW_COUNT;
import static org.apache.phoenix.mapreduce.index.PhoenixScrutinyJobCounters.VALID_ROW_COUNT;
import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

/**
* Tests for the {@link IndexScrutinyTool}
*/
@Category(NeedsOwnMiniClusterTest.class)
public class IndexScrutinyToolForTenantIT extends IndexScrutinyToolBaseIT {
private Connection connGlobal = null;
private Connection connTenant = null;

private String tenantId;
private String tenantViewName;
private String indexNameTenant;
private String multiTenantTable;
private String viewIndexTableName;

private final String createViewStr = "CREATE VIEW %s AS SELECT * FROM %s";
private final String upsertQueryStr = "UPSERT INTO %s (COL1, ID, NAME) VALUES('%s' , %d, '%s')";
private final String createIndexStr = "CREATE INDEX %s ON %s (NAME) ";

/**
* Create the test data
*/
@Before public void setup() throws SQLException {
tenantId = generateUniqueName();
tenantViewName = generateUniqueName();
indexNameTenant = generateUniqueName();
multiTenantTable = generateUniqueName();
viewIndexTableName = "_IDX_" + multiTenantTable;

Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
connGlobal = DriverManager.getConnection(getUrl(), props);

props.setProperty(PhoenixRuntime.TENANT_ID_ATTRIB, tenantId);
connTenant = DriverManager.getConnection(getUrl(), props);
String createTblStr = "CREATE TABLE %s (COL1 VARCHAR(15) NOT NULL,ID INTEGER NOT NULL" + ", NAME VARCHAR, CONSTRAINT PK_1 PRIMARY KEY (COL1, ID)) MULTI_TENANT=true";

createTestTable(getUrl(), String.format(createTblStr, multiTenantTable));

connTenant.createStatement()
.execute(String.format(createViewStr, tenantViewName, multiTenantTable));

String idxStmtTenant = String.format(createIndexStr, indexNameTenant, tenantViewName);
connTenant.createStatement().execute(idxStmtTenant);
}

@After public void teardown() throws SQLException {
if (connGlobal != null) {
connGlobal.close();
}
if (connTenant != null) {
connTenant.close();
}
}

/**
* Tests that the config for max number of output rows is observed
*/
@Test public void testTenantViewAndIndexEqual() throws Exception {
connTenant.createStatement()
.execute(String.format(upsertQueryStr, tenantViewName, tenantId, 1, "x"));
connTenant.commit();

String[]
argValues =
getArgValues("", tenantViewName, indexNameTenant, 10L, SourceTable.INDEX_TABLE_SOURCE, false, null, null, tenantId,
EnvironmentEdgeManager.currentTimeMillis());

List<Job> completedJobs = runScrutiny(argValues);
// Sunny case, both index and view are equal. 1 row
assertEquals(1, completedJobs.size());
for (Job job : completedJobs) {
assertTrue(job.isSuccessful());
Counters counters = job.getCounters();
assertEquals(1, getCounterValue(counters, VALID_ROW_COUNT));
assertEquals(0, getCounterValue(counters, INVALID_ROW_COUNT));
}
}

/**
* Tests global view on multi-tenant table should work too
**/
@Test public void testGlobalViewOnMultiTenantTable() throws Exception {
String globalViewName = generateUniqueName();
String indexNameGlobal = generateUniqueName();

connGlobal.createStatement()
.execute(String.format(createViewStr, globalViewName, multiTenantTable));

String idxStmtGlobal = String.format(createIndexStr, indexNameGlobal, globalViewName);
connGlobal.createStatement().execute(idxStmtGlobal);
connGlobal.createStatement()
.execute(String.format(upsertQueryStr, globalViewName, "global", 5, "x"));
connGlobal.commit();
String[]
argValues =
getArgValues("", globalViewName, indexNameGlobal, 10L, SourceTable.INDEX_TABLE_SOURCE, false, null, null, null,
EnvironmentEdgeManager.currentTimeMillis());
List<Job> completedJobs = runScrutiny(argValues);
// Sunny case, both index and view are equal. 1 row
assertEquals(1, completedJobs.size());
for (Job job : completedJobs) {
assertTrue(job.isSuccessful());
Counters counters = job.getCounters();
assertEquals(1, getCounterValue(counters, VALID_ROW_COUNT));
assertEquals(0, getCounterValue(counters, INVALID_ROW_COUNT));
}
}

@Test public void testColumnsForSelectQueryOnMultiTenantTable() throws Exception {
String indexNameGlobal = generateUniqueName();
connGlobal.createStatement()
.execute(String.format(createIndexStr, indexNameGlobal, multiTenantTable));

PhoenixConnection pconn = connGlobal.unwrap(PhoenixConnection.class);
PTable pDataTable = pconn.getTable(new PTableKey(null, multiTenantTable));
PTable pIndexTable = pconn.getTable(new PTableKey(null, indexNameGlobal));

SourceTargetColumnNames
columnNames =
new SourceTargetColumnNames.IndexSourceColNames(pDataTable, pIndexTable);
String targetPksCsv = Joiner.on(",").join(SchemaUtil.getEscapedFullColumnNames(columnNames.getTargetPkColNames()));
String
selectQuery =
QueryUtil.constructSelectStatement(indexNameGlobal, columnNames.getCastedTargetColNames(), targetPksCsv,
HintNode.Hint.NO_INDEX, false);
assertEquals(selectQuery,
"SELECT /*+ NO_INDEX */ CAST(\"COL1\" AS VARCHAR(15)) , CAST(\"ID\" AS INTEGER) , CAST(\"0\".\"NAME\" AS VARCHAR) FROM "
+ indexNameGlobal + " WHERE (\"COL1\",\"ID\")");
}

/**
* Use Both as source. Add 1 row to tenant view and disable index.
* Add 1 more to view and add a wrong row to index.
* Both have 1 invalid row, 1 valid row.
**/
@Test public void testOneValidOneInvalidUsingBothAsSource() throws Exception {
connTenant.createStatement()
.execute(String.format(upsertQueryStr, tenantViewName, tenantId, 1, "x"));
connTenant.commit();
connTenant.createStatement().execute(
String.format("ALTER INDEX %s ON %S disable", indexNameTenant, tenantViewName));

connTenant.createStatement()
.execute(String.format(upsertQueryStr, tenantViewName, tenantId, 2, "x2"));

connTenant.createStatement().execute(String.format("UPSERT INTO %s (\":ID\", \"0:NAME\") values (%d, '%s')",
indexNameTenant, 5555, "wrongName"));
connTenant.commit();

String[]
argValues =
getArgValues("", tenantViewName, indexNameTenant, 10L, SourceTable.BOTH, false, null, null, tenantId, EnvironmentEdgeManager.currentTimeMillis());
List<Job> completedJobs = runScrutiny(argValues);

assertEquals(2, completedJobs.size());
for (Job job : completedJobs) {
assertTrue(job.isSuccessful());
Counters counters = job.getCounters();
assertEquals(1, getCounterValue(counters, VALID_ROW_COUNT));
assertEquals(1, getCounterValue(counters, INVALID_ROW_COUNT));
}
}

/**
* Add 3 rows to Tenant view.
* Empty index table and observe they are not equal.
* Use data table as source and output to file.
**/
@Test public void testWithEmptyIndexTableOutputToFile() throws Exception {
testWithOutput(OutputFormat.FILE);
}

@Test public void testWithEmptyIndexTableOutputToTable() throws Exception {
testWithOutput(OutputFormat.TABLE);
assertEquals(3, countRows(connGlobal, OUTPUT_TABLE_NAME));
}

private void testWithOutput(OutputFormat outputFormat) throws Exception {
connTenant.createStatement()
.execute(String.format(upsertQueryStr, tenantViewName, tenantId, 1, "x"));
connTenant.createStatement()
.execute(String.format(upsertQueryStr, tenantViewName, tenantId, 2, "x2"));
connTenant.createStatement()
.execute(String.format(upsertQueryStr, tenantViewName, tenantId, 3, "x3"));
connTenant.createStatement().execute(String.format("UPSERT INTO %s (\":ID\", \"0:NAME\") values (%d, '%s')",
indexNameTenant, 5555, "wrongName"));
connTenant.commit();

ConnectionQueryServices queryServices = connGlobal.unwrap(PhoenixConnection.class).getQueryServices();
Admin admin = queryServices.getAdmin();
TableName tableName = TableName.valueOf(viewIndexTableName);
admin.disableTable(tableName);
admin.truncateTable(tableName, false);

String[]
argValues =
getArgValues("", tenantViewName, indexNameTenant, 10L, SourceTable.DATA_TABLE_SOURCE, true, outputFormat, null,
tenantId, EnvironmentEdgeManager.currentTimeMillis());
List<Job> completedJobs = runScrutiny(argValues);

assertEquals(1, completedJobs.size());
for (Job job : completedJobs) {
assertTrue(job.isSuccessful());
Counters counters = job.getCounters();
assertEquals(0, getCounterValue(counters, VALID_ROW_COUNT));
assertEquals(3, getCounterValue(counters, INVALID_ROW_COUNT));
}
}
}

Loading