New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multistage] Make join operator more resilient #11401
Conversation
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
17e4ab3
to
c2e4689
Compare
Codecov Report
@@ Coverage Diff @@
## master #11401 +/- ##
============================================
+ Coverage 62.89% 62.91% +0.02%
- Complexity 1079 1091 +12
============================================
Files 2301 2301
Lines 123699 123766 +67
Branches 18816 18833 +17
============================================
+ Hits 77803 77873 +70
+ Misses 40367 40355 -12
- Partials 5529 5538 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5c39b24
to
76d463c
Compare
76d463c
to
71eedba
Compare
71eedba
to
8733b7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/JoinNode.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/AbstractPlanNode.java
Outdated
Show resolved
Hide resolved
@@ -228,6 +305,13 @@ private TransferableBlock buildJoinedDataBlock(TransferableBlock leftBlock) | |||
return new TransferableBlock(rows, _resultSchema, DataBlock.Type.ROW); | |||
} | |||
|
|||
private TransferableBlock setPartialResultExceptionToBlock(TransferableBlock block) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if we read exception from the data block and EOS block? I feel they are just ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are ignored right now. Need to open up another thread to fix this.
8733b7d
to
9847966
Compare
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java
Outdated
Show resolved
Hide resolved
54b4ea6
to
0c2d050
Compare
0c2d050
to
5c36a12
Compare
* Support hash join right table protection * early terminate right table operator
* Support hash join right table protection * early terminate right table operator
To protect the server from OOM, this PR introduces the limit for join operator to ensure the memory consumption is limited.
THROW
/BREAK
pinot.query.join.overflow.mode=THROW
SET joinOverflowMode='THROW'
join_overflow_mode='THROW'
pinot.query.join.max.rows=100000
SET maxRowsInJoin=1000000
max_rows_in_join='1000000'
joinOverflowMode = BREAK
;TODO: Support size based limit.
Examples:
Sample screenshot for:
0. Normal run without limit hit: (Joined result is 47735)
More examples of difference between the threshold, and overflow mode: