[multistage] Change default limit to 10 for query.#11418
Closed
xiangfu0 wants to merge 1 commit intoapache:masterfrom
Closed
[multistage] Change default limit to 10 for query.#11418xiangfu0 wants to merge 1 commit intoapache:masterfrom
xiangfu0 wants to merge 1 commit intoapache:masterfrom
Conversation
xiangfu0
force-pushed
the
default-limit-10
branch
11 times, most recently
from
790eb7e to
30f6466
Compare
Codecov Report
@@ Coverage Diff @@
## master #11418 +/- ##
============================================
- Coverage 62.97% 62.95% -0.03%
+ Complexity 1111 1110 -1
============================================
Files 2319 2319
Lines 124394 124413 +19
Branches 18992 18998 +6
============================================
- Hits 78340 78322 -18
- Misses 40489 40523 +34
- Partials 5565 5568 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
force-pushed
the
default-limit-10
branch
2 times, most recently
from
729a6c7 to
0587878
Compare
xiangfu0
force-pushed
the
default-limit-10
branch
from
0587878 to
723d772
Compare
xiangfu0
force-pushed
the
default-limit-10
branch
from
723d772 to
e9c5946
Compare
walterddr
reviewed
Sep 15, 2023
Contributor
There was a problem hiding this comment.
i am not sure this is the right way to handle un-limited queries. it make sense to rewrite the query in simple single-table way but this might back-fire.
if the goal is not to blow up when un-reasonably large queries are issues. we should directly set the limit similar to #11401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.