Add back 'numRowsResultSet' to BrokerResponse, and retain it when result table is hidden #13198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult table id hidden
klsince
approved these changes
May 21, 2024
klsince
reviewed
May 21, 2024
|
|
||
| @Override | ||
| public int getNumRowsResultSet() { | ||
| return _numRowsResultSet; |
There was a problem hiding this comment.
add setNumRowsResultSet() as well?
There was a problem hiding this comment.
I didn't add it intentionally because we want to always set it along with the result table
There was a problem hiding this comment.
I added it for V1 response for JSON ser/de purpose, which is not supported in V2 response as of now
gortiz
pushed a commit
to gortiz/pinot
that referenced
this pull request
Jun 14, 2024
…ult table id hidden (apache#13198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was removed in #13179