Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move table config into pinot-spi #5194

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Move table config into pinot-spi #5194

merged 1 commit into from
Mar 30, 2020

Commits on Mar 29, 2020

  1. Move table config into pinot-spi 

    Motivation:
- Table config should be moved to pinot-spi so that user interface can access it (e.g. segment generation spec)

Changes:
- Make all configs POJO like, and Json serializable for backward-compatibility
- De-couple the Helix properties and utils from the configs
- Add the TableConfigSerDeTest to check all the serialization/de-serialization

Side changes:
- Refactor DataSizeUtils (from DataSize), integrate StorageQuotaChecker and HelixExternalViewBasedQueryQuotaManager with the POJO like QuotaConfig
- TextIndexConfigValidator is integrated into `TableConfigUtils.validate(TableConfig tableConfig)`

BACKWARD-INCOMPATIBILITY:
- TableConfig no longer support de-serialization from json string of nested json string (i.e. no `\"` inside the json)
    @Jackie-Jiang
    Jackie-Jiang committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    0e3bdaf View commit details
    Browse the repository at this point in the history