Move table config into pinot-spi #5194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
table_config_spi
branch
from
a6fc4e9
to
1e05504
Compare
siddharthteotia
approved these changes
Mar 28, 2020
Jackie-Jiang
force-pushed
the
table_config_spi
branch
4 times, most recently
from
0e719fc
to
8ea3f80
Compare
Motivation: - Table config should be moved to pinot-spi so that user interface can access it (e.g. segment generation spec) Changes: - Make all configs POJO like, and Json serializable for backward-compatibility - De-couple the Helix properties and utils from the configs - Add the TableConfigSerDeTest to check all the serialization/de-serialization Side changes: - Refactor DataSizeUtils (from DataSize), integrate StorageQuotaChecker and HelixExternalViewBasedQueryQuotaManager with the POJO like QuotaConfig - TextIndexConfigValidator is integrated into `TableConfigUtils.validate(TableConfig tableConfig)` BACKWARD-INCOMPATIBILITY: - TableConfig no longer support de-serialization from json string of nested json string (i.e. no `\"` inside the json)
Jackie-Jiang
force-pushed
the
table_config_spi
branch
from
8ea3f80
to
0e3bdaf
Compare
Codecov Report
@@ Coverage Diff @@
## master #5194 +/- ##
============================================
- Coverage 65.95% 65.83% -0.13%
Complexity 12 12
============================================
Files 1052 1055 +3
Lines 54170 54096 -74
Branches 8078 8047 -31
============================================
- Hits 35729 35615 -114
- Misses 15795 15834 +39
- Partials 2646 2647 +1
Continue to review full report at Codecov.
|
jackjlli
reviewed
Mar 29, 2020
| quotaConfig.getMaxQueriesPerSecond(), tableNameWithType); | ||
| return; | ||
| } | ||
| double overallRate = Double.parseDouble(quotaConfig.getMaxQueriesPerSecond()); |
There was a problem hiding this comment.
parseDouble would throw NumberFormatException if the the input string isn't a valid number.
| @@ -83,11 +84,11 @@ public void setUp() | |||
| .addTime(TIME_COLUMN_NAME, TimeUnit.DAYS, FieldSpec.DataType.INT).build(); | |||
| _helixResourceManager.addSchema(schema, true); | |||
| TableConfig offlineTableConfig = | |||
| new TableConfig.Builder(TableType.OFFLINE).setTableName(RAW_TABLE_NAME).setTimeColumnName(TIME_COLUMN_NAME) | |||
| new TableConfigBuilder(TableType.OFFLINE).setTableName(RAW_TABLE_NAME).setTimeColumnName(TIME_COLUMN_NAME) | |||
There was a problem hiding this comment.
Why does the builder need to be a public class instead of an inner class?
There was a problem hiding this comment.
To keep the config class clean and maintain the builder as an util class. There are multiple ways to get the table config: using a builder; deserialize from json; construct from ZNRecord.
| @@ -184,7 +185,7 @@ public void run() | |||
|
|
|||
| private TableConfig getTableConfig(String tableName) | |||
| throws Exception { | |||
| return TableConfig.fromZnRecord( | |||
| return TableConfigUtils.fromZNRecord( | |||
There was a problem hiding this comment.
There are multiple ways to convert to TableConfig, like TableConfigUtils and Builder. Can they be unified to one class?
There was a problem hiding this comment.
No because ZNRecord is a Helix specific concept which should not be pulled into the pinot-spi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Changes:
Side changes:
TableConfigUtils.validate(TableConfig tableConfig)BACKWARD-INCOMPATIBILITY:
\"inside the json)