Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access control for Pinot server segment download api. #5260

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Add access control for Pinot server segment download api. #5260

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d7aa45
Add access control for Pinot server segment download api.
chenboat Apr 16, 2020
e86d31c
Update pinot-server/src/main/java/org/apache/pinot/server/starter/hel…
chenboat Apr 17, 2020
fdc45f7
Revise based on comments.
chenboat Apr 17, 2020
3c4bb0b
Revise based on comments.
chenboat Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
import org.apache.pinot.server.realtime.ServerSegmentCompletionProtocolHandler;
import org.apache.pinot.server.starter.ServerInstance;
import org.apache.pinot.spi.filesystem.PinotFSFactory;
import org.apache.pinot.spi.plugin.PluginManager;
import org.apache.pinot.spi.utils.builder.TableNameBuilder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -159,9 +160,11 @@ public HelixServerStarter(String helixClusterName, String zkAddress, Configurati
LOGGER.info("Using class: {} as the AccessControlFactory", accessControlFactoryClass);
final AccessControlFactory accessControlFactory;
try {
accessControlFactory = (AccessControlFactory) Class.forName(accessControlFactoryClass).newInstance();
accessControlFactory = PluginManager.get().createInstance(accessControlFactoryClass);
} catch (Exception e) {
throw new RuntimeException("Caught exception while creating new AccessControlFactory instance", e);
throw new RuntimeException(
"Caught exception while creating new AccessControlFactory instance in class " + this.getClass()
chenboat marked this conversation as resolved.
Show resolved Hide resolved
.getSimpleName(), e);
}

int adminApiPort = _serverConf.getInt(CONFIG_OF_ADMIN_API_PORT, DEFAULT_ADMIN_API_PORT);
Expand Down