Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access control for Pinot server segment download api. #5260

Merged
merged 4 commits into from Apr 20, 2020

Conversation

chenboat
Copy link
Contributor

@chenboat chenboat commented Apr 16, 2020

Add access control for Pinot server segment download api. Borrow most of the classes from the controller access control api.

@mcvsubbu @Jackie-Jiang

@codecov-io
Copy link

Codecov Report

Merging #5260 into master will decrease coverage by 8.93%.
The diff coverage is 61.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5260      +/-   ##
============================================
- Coverage     65.90%   56.96%   -8.94%     
============================================
  Files          1052     1068      +16     
  Lines         54170    54336     +166     
  Branches       8078     8078              
============================================
- Hits          35702    30955    -4747     
- Misses        15819    20968    +5149     
+ Partials       2649     2413     -236     
Impacted Files Coverage Δ Complexity Δ
...e/pinot/broker/api/resources/PinotBrokerDebug.java 0.00% <ø> (-76.67%) 0.00 <0.00> (ø)
...pinot/broker/api/resources/PinotClientRequest.java 0.00% <0.00%> (-23.41%) 0.00 <0.00> (ø)
.../BrokerResourceOnlineOfflineStateModelFactory.java 41.86% <ø> (-13.96%) 0.00 <0.00> (ø)
.../pinot/broker/broker/helix/HelixBrokerStarter.java 70.70% <ø> (-1.28%) 0.00 <0.00> (ø)
...roker/requesthandler/BaseBrokerRequestHandler.java 20.37% <0.00%> (-59.26%) 0.00 <0.00> (ø)
...thandler/SingleConnectionBrokerRequestHandler.java 12.19% <ø> (-80.49%) 0.00 <0.00> (ø)
...ting/instanceselector/InstanceSelectorFactory.java 71.42% <ø> (ø) 0.00 <0.00> (ø)
...er/routing/segmentpruner/SegmentPrunerFactory.java 83.33% <ø> (ø) 0.00 <0.00> (ø)
...outing/segmentselector/SegmentSelectorFactory.java 60.00% <ø> (ø) 0.00 <0.00> (ø)
...oker/routing/timeboundary/TimeBoundaryManager.java 87.50% <ø> (ø) 0.00 <0.00> (ø)
... and 560 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20ace0...5d7aa45. Read the comment docs.

chenboat and others added 2 commits April 17, 2020 14:24
…ix/HelixServerStarter.java

Co-Authored-By: Subbu Subramaniam <mcvsubbu@users.noreply.github.com>
@chenboat chenboat requested a review from mcvsubbu April 17, 2020 21:38
@chenboat chenboat requested a review from mcvsubbu April 17, 2020 22:23
@mcvsubbu mcvsubbu merged commit 52472b3 into apache:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants