-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access control for Pinot server segment download api. #5260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5260 +/- ##
============================================
- Coverage 65.90% 56.96% -8.94%
============================================
Files 1052 1068 +16
Lines 54170 54336 +166
Branches 8078 8078
============================================
- Hits 35702 30955 -4747
- Misses 15819 20968 +5149
+ Partials 2649 2413 -236
Continue to review full report at Codecov.
|
mcvsubbu
reviewed
Apr 16, 2020
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
Outdated
Show resolved
Hide resolved
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
Outdated
Show resolved
Hide resolved
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
Outdated
Show resolved
Hide resolved
…ix/HelixServerStarter.java Co-Authored-By: Subbu Subramaniam <mcvsubbu@users.noreply.github.com>
mcvsubbu
reviewed
Apr 17, 2020
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
Outdated
Show resolved
Hide resolved
mcvsubbu
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add access control for Pinot server segment download api. Borrow most of the classes from the controller access control api.
@mcvsubbu @Jackie-Jiang