Fix SegmentCompletionProtocol to ignore unknown json fields #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our compatibility guarantees are around upgrading the controller first and then the broker and then the server. So, it is possible that the controller sends a new field in the response (in SegmentCompletionProtocol) The server should ignore new fields that it does not understand
| @@ -395,6 +396,7 @@ public SegmentStoppedConsuming(Params params) { | |||
| public Response() { | |||
| } | |||
|
|
|||
| @JsonIgnoreProperties(ignoreUnknown = true) | |||
There was a problem hiding this comment.
This line should be added before line 388
There was a problem hiding this comment.
good catch, thanks
Jackie-Jiang
approved these changes
May 12, 2020
|
Issue #5359 This change must go into 0.4.0 |
mcvsubbu
added
backward-incompat
|
@haibow please make sure this commit gets into 0.4.0 thanks |
Codecov Report
@@ Coverage Diff @@
## master #5376 +/- ##
==========================================
- Coverage 66.44% 56.97% -9.47%
==========================================
Files 1075 1079 +4
Lines 54773 55004 +231
Branches 8168 8237 +69
==========================================
- Hits 36396 31341 -5055
- Misses 15700 21190 +5490
+ Partials 2677 2473 -204
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our compatibility guarantees are around upgrading the controller first
and then the broker and then the server. So, it is possible that the
controller sends a new field in the response (in SegmentCompletionProtocol)
The server should ignore new fields that it does not understand