Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SegmentCompletionProtocol to ignore unknown json fields #5376

Merged
merged 3 commits into from
May 12, 2020
Merged

Fix SegmentCompletionProtocol to ignore unknown json fields #5376

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03c48e4
Fix SegmentCompletionProtocol to ignore unknown json fields
mcvsubbu May 12, 2020
d4a8f9f
Moved the json ignore line to the correct place
mcvsubbu May 12, 2020
6f83446
Merge branch 'master' into json-ignore-on-server
mcvsubbu May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package org.apache.pinot.common.protocols;

import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.JsonProcessingException;
Expand Down Expand Up @@ -384,6 +385,7 @@ public SegmentStoppedConsuming(Params params) {
}
}

@JsonIgnoreProperties(ignoreUnknown = true)
public static class Response {
private ControllerResponseStatus _status;
private long _offset = -1;
Expand Down