Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary work-around to bypass function arguments being treated as expressions with columns. #5382

Merged
merged 1 commit into from
May 14, 2020
Merged

Temporary work-around to bypass function arguments being treated as expressions with columns. #5382

merged 1 commit into from
May 14, 2020

Commits on May 14, 2020

  1. Temporary work-around to bypass function arguments being treated as e… 

    …xpressions with columns.

Only aggregation functions have the knowledge on how to interpret their arguments.
However, the assumption within ServerQueryRequest is that all expression arguments will contain
columns to be collected. A clean fix would be to create aggregation functions upfront and let
them interpret the arguments. However, until that happens, working-around by assuming that first
argument contains all the columns (to be used by DataSchemaPruner), which is true for all functions.

A side effect would be that DataSchemaPruner won't work for DistinctCountThetaSketchAggregatinoFunction.
But since this pruner is only for schema mis-matches, and not for performance, there should not be
an impact.
    @mayankshriv
    mayankshriv committed May 14, 2020
    Configuration menu
    Copy the full SHA
    3649567 View commit details
    Browse the repository at this point in the history