Temporary work-around to bypass function arguments being treated as expressions with columns. #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
May 14, 2020
pinot-core/src/main/java/org/apache/pinot/core/query/request/ServerQueryRequest.java
Show resolved
Hide resolved
…xpressions with columns. Only aggregation functions have the knowledge on how to interpret their arguments. However, the assumption within ServerQueryRequest is that all expression arguments will contain columns to be collected. A clean fix would be to create aggregation functions upfront and let them interpret the arguments. However, until that happens, working-around by assuming that first argument contains all the columns (to be used by DataSchemaPruner), which is true for all functions. A side effect would be that DataSchemaPruner won't work for DistinctCountThetaSketchAggregatinoFunction. But since this pruner is only for schema mis-matches, and not for performance, there should not be an impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only aggregation functions have the knowledge on how to interpret their arguments.
However, the assumption within ServerQueryRequest is that all expression arguments will contain
columns to be collected. A clean fix would be to create aggregation functions upfront and let
them interpret the arguments. However, until that happens, working-around by assuming that first
argument contains all the columns (to be used by DataSchemaPruner), which is true for all functions.
A side effect would be that DataSchemaPruner won't work for DistinctCountThetaSketchAggregatinoFunction.
But since this pruner is only for schema mis-matches, and not for performance, there should not be
an impact.