Introduce RawThetaSketchAggregationFunction #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishoreg
approved these changes
Sep 3, 2020
| @@ -43,6 +43,7 @@ | |||
| PERCENTILE("percentile"), | |||
| PERCENTILEEST("percentileEst"), | |||
| PERCENTILETDIGEST("percentileTDigest"), | |||
| THETASKETCH("thetaSketch"), | |||
There was a problem hiding this comment.
should we call it THETHASKETCHRAW
There was a problem hiding this comment.
Done, changed to rawThetaSketch
Jackie-Jiang
force-pushed
the
raw_theta_sketch
branch
from
ed89e9e
to
26a1be7
Compare
Jackie-Jiang
force-pushed
the
raw_theta_sketch
branch
from
26a1be7
to
6f3bc60
Compare
Jackie-Jiang
changed the title
Jackie-Jiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
RawThetaSketchAggregationFunctionwhich collects the values for a given expression (can be single-valued or multi-valued) into a Sketch object, and returns the sketch as a base64 encoded string. It treatsBYTESexpression as serialized sketches.It takes an optional second argument as the parameters for the function, e.g.
RAW_THETA_SKETCH(col, 'nominalEntries=8192').