Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segemnt uploader property in auth quickstart #7479

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

apucher
Copy link
Contributor

@apucher apucher commented Sep 24, 2021

Description

fixes the property key for the controller's segment uploader auth token in AuthQuickstart

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #7479 (c147ca1) into master (fcae6e0) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7479      +/-   ##
============================================
+ Coverage     71.91%   71.94%   +0.03%     
+ Complexity     3365     3364       -1     
============================================
  Files          1519     1519              
  Lines         75341    75364      +23     
  Branches      10985    10987       +2     
============================================
+ Hits          54181    54221      +40     
+ Misses        17515    17491      -24     
- Partials       3645     3652       +7     
Flag Coverage Δ
integration1 30.34% <ø> (-0.01%) ⬇️
integration2 29.12% <ø> (+0.02%) ⬆️
unittests1 69.82% <ø> (+<0.01%) ⬆️
unittests2 14.51% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nction/DistinctCountBitmapAggregationFunction.java 41.75% <0.00%> (-7.74%) ⬇️
...gregation/function/StUnionAggregationFunction.java 71.42% <0.00%> (-2.86%) ⬇️
...nMaxValueBasedSelectionOrderByCombineOperator.java 72.80% <0.00%> (-2.41%) ⬇️
...not/broker/broker/helix/ClusterChangeMediator.java 78.02% <0.00%> (-2.20%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 86.52% <0.00%> (-2.13%) ⬇️
...verttorawindex/ConvertToRawIndexTaskGenerator.java 85.96% <0.00%> (-1.54%) ⬇️
...e/pinot/segment/local/io/util/PinotDataBitSet.java 95.62% <0.00%> (-1.46%) ⬇️
...lix/core/realtime/PinotRealtimeSegmentManager.java 82.90% <0.00%> (-1.04%) ⬇️
...manager/realtime/LLRealtimeSegmentDataManager.java 73.17% <0.00%> (-0.28%) ⬇️
.../aggregation/function/ModeAggregationFunction.java 88.14% <0.00%> (-0.27%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcae6e0...c147ca1. Read the comment docs.

@apucher apucher merged commit 8a05ad8 into master Sep 24, 2021
@apucher apucher deleted the auth-quickstart-property-fix branch September 24, 2021 18:17
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants