replication factor to be obtained from tenant configuration in case of dimension table #7848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f dimension table
Jackie-Jiang
approved these changes
Dec 1, 2021
|
@Jackie-Jiang , I have fixed the lint issue |
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
…f dimension table (apache#7848)
cbalci
added a commit
to cbalci/pinot
that referenced
this pull request
Dec 16, 2021
…n case of dimension table (apache#7848)" This reverts commit 41c98d7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As Dimension table are replicated on all the server by default, we should be getting the replication factor by taking the tenant id and number of server present in the tenant id. This would ensure that the allowedSize is calculated properly
Issue Link: #7843