Disable JsonStatementOptimizer. #7919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7919 +/- ##
============================================
- Coverage 71.32% 71.16% -0.17%
- Complexity 4092 4115 +23
============================================
Files 1589 1593 +4
Lines 82139 82365 +226
Branches 12270 12270
============================================
+ Hits 58589 58614 +25
- Misses 19578 19805 +227
+ Partials 3972 3946 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
Dec 17, 2021
| @@ -51,7 +50,7 @@ | |||
| new TimePredicateFilterOptimizer(), new MergeRangeFilterOptimizer()); | |||
|
|
|||
| private static final List<StatementOptimizer> STATEMENT_OPTIMIZERS = | |||
| Arrays.asList(new JsonStatementOptimizer(), new StringPredicateFilterOptimizer()); | |||
| Arrays.asList(new StringPredicateFilterOptimizer()); | |||
There was a problem hiding this comment.
(minor) Collections.singletonList() instead
siddharthteotia
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabling JsonStatementOptimizer (the class that processes identifier dot notation on JSON columns), until we can gain more confidence in using dot notation.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation