Add minion health check endpoint #8574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8574 +/- ##
============================================
- Coverage 70.71% 70.64% -0.07%
- Complexity 4314 4315 +1
============================================
Files 1690 1691 +1
Lines 88605 88624 +19
Branches 13438 13442 +4
============================================
- Hits 62654 62608 -46
- Misses 21567 21625 +58
- Partials 4384 4391 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
Apr 22, 2022
| @@ -493,7 +493,7 @@ protected void configure() { | |||
|
|
|||
| private ServiceStatus.ServiceStatusCallback generateServiceStatusCallback(HelixManager helixManager) { | |||
| return new ServiceStatus.ServiceStatusCallback() { | |||
| private boolean _isStarted = false; | |||
| private volatile boolean _isStarted = false; | |||
There was a problem hiding this comment.
Good catch. _statusDescription might also need to be volatile
saurabhd336
force-pushed
the
minionHealthCheck
branch
from
1503ea4
to
6e1eace
Compare
npawar
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add /health API to minion
GH issue: #8515