Enable minion liveness probe #8593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npawar
approved these changes
Apr 26, 2022
|
@xiangfu0 any idea why livenessProbe and readiness is false for controller and server? |
|
The only thing I can think of is to have the deployment/restart procedure faster for testing. |
saurabhd336
added a commit
to saurabhd336/pinot
that referenced
this pull request
May 6, 2022
This reverts commit 89836a5.
xiangfu0
pushed a commit
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/health endpoint was added to minion with https://github.com/apache/pinot/pull/8574/files. This change enables k8s liveness and readiness probes for minion.