[Feature] Support function registry with arg types #9397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
61yao
commented
Sep 14, 2022
61yao
commented
- Functions are registered using FunctionName and DataType (converted from Java type)
- To make this fully work, we have to support all literal passing from SqlNode to Thrift so we can support all LiteralType
| * <p>TODO: Merge FunctionRegistry and FunctionDefinitionRegistry to provide one single registry for all functions. | ||
| */ | ||
| public class FunctionRegistry { | ||
| private FunctionRegistry() { | ||
| } | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(FunctionRegistry.class); | ||
|
|
||
| // Map from function name to parameter types to function info. | ||
| private static final Map<String, Map<List<FieldSpec.DataType>, FunctionInfo>> FUNC_PARAM_INFO_MAP = new HashMap<>(); |
There was a problem hiding this comment.
Suggest making the value a separate class, which can be used to look up the FunctionInfo with a list of argument types. That way we don't need to maintain 2 maps, and can support type matching (match int argument to long parameter function) in the future.
| * <p>TODO: Merge FunctionRegistry and FunctionDefinitionRegistry to provide one single registry for all functions. | ||
| */ | ||
| public class FunctionRegistry { | ||
| private FunctionRegistry() { | ||
| } | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(FunctionRegistry.class); | ||
|
|
||
| // Map from function name to parameter types to function info. | ||
| private static final Map<String, Map<List<FieldSpec.DataType>, FunctionInfo>> FUNC_PARAM_INFO_MAP = new HashMap<>(); |
There was a problem hiding this comment.
We might want to use ColumnDataType here which contains the SV/MV info
| @@ -92,11 +138,17 @@ public static void registerFunction(Method method, boolean nullableParameters) { | |||
| * Registers a method with the given function name. | |||
| */ | |||
| public static void registerFunction(String functionName, Method method, boolean nullableParameters) { | |||
| FunctionInfo functionInfo = new FunctionInfo(method, method.getDeclaringClass(), nullableParameters); | |||
| String canonicalName = canonicalize(functionName); | |||
| final FunctionInfo functionInfo = new FunctionInfo(method, method.getDeclaringClass(), nullableParameters); | |||
There was a problem hiding this comment.
(convention) We don't usually put final for local variables
|
This one relies on #9389. We can first finish that and get back to this |
SG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.