[feature] coalesce scalar #9487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Sep 30, 2022
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9487 +/- ##
=============================================
- Coverage 68.72% 25.93% -42.80%
+ Complexity 4860 44 -4816
=============================================
Files 1924 1913 -11
Lines 102425 102164 -261
Branches 15542 15516 -26
=============================================
- Hits 70392 26492 -43900
- Misses 26994 73005 +46011
+ Partials 5039 2667 -2372
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
approved these changes
Oct 3, 2022
added 2 commits
October 3, 2022 14:49
|
I think this PR will do the ideal solution for function registry #9397 |
siddharthteotia
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support coalesce scalar.
Since we only register function with param count now and coalesce has various # of parameters, this PR hardcode 1-5 arguments for coalesce scalar.
Long term plan is to support function registry with var # of args.