Skip to content

Commit

Permalink
refactor(codegen/plc4go): if an enum is unknown return a ParseAssertE…
Browse files Browse the repository at this point in the history
…rror instead of a generic error
  • Loading branch information
sruehl committed Jul 12, 2022
1 parent 2f17300 commit 2ba1332
Show file tree
Hide file tree
Showing 168 changed files with 336 additions and 168 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ ${helper.fileName(protocolName, languageName, outputFlavor)?replace(".", "/")}/m
package model

import (
"fmt"
"github.com/apache/plc4x/plc4go/internal/spi/utils"
"github.com/pkg/errors"
)
Expand Down Expand Up @@ -183,7 +184,7 @@ func ${type.name}Parse(readBuffer utils.ReadBuffer) (${type.name}, error) {
return <#if type.type.orElseThrow().isStringTypeReference() || type.type.orElseThrow().isVstringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>, errors.Wrap(err, "error reading ${type.name}")
}
if enum, ok := ${type.name}ByValue(val); !ok {
return <#if type.type.orElseThrow().isStringTypeReference() || type.type.orElseThrow().isVstringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>, errors.Errorf("no value %v found for ${type.name}", val)
return <#if type.type.orElseThrow().isStringTypeReference() || type.type.orElseThrow().isVstringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>, utils.ParseAssertError{Message: fmt.Sprintf("no value %v found for ${type.name}", val)}
} else {
return enum, nil
}
Expand Down
3 changes: 2 additions & 1 deletion plc4go/protocols/ads/readwrite/model/AdsDataType.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion plc4go/protocols/ads/readwrite/model/CommandId.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion plc4go/protocols/ads/readwrite/model/ReservedIndexGroups.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion plc4go/protocols/ads/readwrite/model/ReturnCode.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion plc4go/protocols/bacnetip/readwrite/model/ApduType.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion plc4go/protocols/bacnetip/readwrite/model/BACnetAction.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2ba1332

Please sign in to comment.