Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize timeout handling in plc4j-spi #821

Closed
1 of 16 tasks
splatch opened this issue Feb 23, 2023 · 2 comments
Closed
1 of 16 tasks

Reorganize timeout handling in plc4j-spi #821

splatch opened this issue Feb 23, 2023 · 2 comments

Comments

@splatch
Copy link
Contributor

splatch commented Feb 23, 2023

What would you like to happen?

The timeout handling in plc4j is affected by its own logic where registered handlers are called only when packets arrive. This means that in some cases, when communication line is broken or simply hanged, timeouts may never be reported back to driver.

There were several attempts to fix that, however none of them have worked. The recent work in #818 shed some light on some of netty utilities which could be wired into the spi to separate timeout handling. Given that our use of netty in plc4j is never ending source of troubles and confusion (it orchestrates a lot!), we may consider introducing new SPI types to hide specifics, even between our own internals.

Programming Languages

  • plc4j
  • plc4go
  • plc4c
  • plc4net

Protocols

  • AB-Ethernet
  • ADS /AMS
  • BACnet/IP
  • CANopen
  • DeltaV
  • DF1
  • EtherNet/IP
  • Firmata
  • KNXnet/IP
  • Modbus
  • OPC-UA
  • S7
splatch added a commit that referenced this issue Feb 23, 2023
Signed-off-by: Łukasz Dywicki <luke@code-house.org>
splatch added a commit that referenced this issue Feb 23, 2023
Signed-off-by: Łukasz Dywicki <luke@code-house.org>
spnettec added a commit to spnettec/plc4x that referenced this issue Feb 26, 2023
spnettec added a commit to spnettec/plc4x that referenced this issue Feb 27, 2023
splatch added a commit that referenced this issue Jun 3, 2023
Signed-off-by: Łukasz Dywicki <luke@code-house.org>
@splatch
Copy link
Contributor Author

splatch commented Jun 30, 2023

Addressed through #822.

@splatch splatch closed this as completed Jun 30, 2023
@spnettec
Copy link

spnettec commented Jul 3, 2023

Good job. @splatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants