feat(plc4j) Better handling of timeouts in plc4j (#821).

[splatch]

The tricky part I was not able to solve yet is how to wire custom timeout manager into the driver. The configuration instances we have are not well defined and passing them around is not clear to me.

[spnettec]

The tricky part I was not able to solve yet is how to wire custom timeout manager into the driver. The configuration instances we have are not well defined and passing them around is not clear to me.

I think we can config in the driver

    @ConfigurationParameter("timeout-request")
    @IntDefaultValue(4000)
    protected int timeoutRequest;

    @Override
    public TimeoutManager getTimeoutManager() {
        return new TimeoutManager(){

            @Override
            public CompletionCallback register(TimedOperation operation) {
                // return null;
                // here do something
            }

            @Override
            public void stop() {
                 // here do something
            }
        };
    }

And send request like this

transaction.submit(() -> context.sendRequest(tpktPacket)
            .onTimeout(new TransactionErrorCallback<>(future, transaction))
            .onError(new TransactionErrorCallback<>(future, transaction))
            .expectResponse(TPKTPacket.class, Duration.ofMillis(configuration.getTimeoutRequest()))
            .check(p -> p.getPayload() instanceof COTPPacketData)
            .unwrap(p -> ((COTPPacketData) p.getPayload()))
            .unwrap(COTPPacket::getPayload)
            .check(p -> p.getTpduReference() == tpduId)

[spnettec]

Here we should stop TimeManager

[splatch]

You're right, however I am not entirely sure of netty vs plc4x lifecycle. Namely can we reestablish connection once we reached that point? At high level plc4x drivers support connect call, we would need to assure that it always configure fresh pipeline and uses new timeout manager forcing netty to fire bootstrap procedure again.

[spnettec]

Fresh pipeline finnaly always invoke PlcConnectionManager.getConnection it will create fesh pipeline. If you don't stop the TimeManager it will caouse memory leak

[splatch]

Thanks for initial review, were you able to test this PR against your environment?

[spnettec]

Thanks for initial review, were you able to test this PR against your environment?

What's you changed?

[splatch]

This PR was open for quite long time. I'm going to address @spnettec review comments in separate change set.