fix(plc4go/modbus): Delete elements in the loop, and the index is dec… #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remented by 1 at the same time
sruehl
requested changes
Jul 12, 2023
There was a problem hiding this comment.
Please add a unit test for this change. It is such a central change which needs a test to proof the failure before the change and that it is working right after the change. The test then I can try out on the current develop to understand what exactly is happening
|
Small note: you can add a testcase in |
|
And looking at it: And easy fix would be to break the loop after we found someone who accepted the message. There should be only one at a time accepting the message I think |
…ge to all handlers.
sruehl
approved these changes
Jul 12, 2023
Thanks for reviewing and adding testcase 😎 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some batch read/write cases, because the element is deleted in the loop, but the index is not decremented by 1, the program freezes, and even the timeout does not work.