feat(plc4j/drivers): Create maven meta package to include all drivers #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way users do not need to explicitly list all drivers in their projects, and to update it whenever a driver is added or removed.
splatch
reviewed
Oct 19, 2023
chrisdutz
reviewed
Oct 19, 2023
| @@ -88,15 +88,16 @@ | |||
|
|
|||
| <dependency> | |||
| <groupId>org.apache.plc4x</groupId> | |||
| <artifactId>plc4j-driver-simulated</artifactId> | |||
| <artifactId>plc4j-driver-plc4x</artifactId> | |||
There was a problem hiding this comment.
Woudln't the plc4x driver be part of the all package?
There was a problem hiding this comment.
Yes, but in plc4x-server this is the only driver that is needed at compile time too, not just runtime, because this application uses types from that driver.
There was a problem hiding this comment.
Odd ... why is this driver needed at compile-time?
There was a problem hiding this comment.
LOL ... forgett it ... stupid me ;) ... It#s the PLC4X server, which is the server host for the PLC4X client driver. Of cours does it require these types. I was sort of thinking of the OPC-UA Server module instead ... please ignore my mumbling ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way users do not need to explicitly list all drivers in their projects, and to update it whenever a driver is added or removed.