PLC4X-307 Add support for custom generator options / customized packages #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ships a new 'package' parameter for Java code generator which lets to specify root package of generated code.
In case if types for serializer ot driver test suite are in custom package they might be pointed via 'package' option. By default above will always fallback to 'org.apache.plc4x' packages to keep backward compatybility.
sruehl
approved these changes
Jul 29, 2021
chrisdutz
approved these changes
Jul 29, 2021
I agree, it is indeed yet another string trap. I'd wish we could migrate to typed configuration and minimize amount of arguments passed over test framework (language, protocolName, driverName). Yet for that I believe we need to book some exclusive time reserved only for test framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits are follow up to build tools changes. First commit makes sure generators are fine and can compile, other one opens test framework for use of customized output packages.