Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cdutz/go ads ng (Streamlining of PLC4X API in PLC4Go and PLC4J) #576

Merged
merged 34 commits into from
Nov 10, 2022

Commits on Nov 1, 2022

  1. chore(protocols): Added a pointer to a possibly interesting protocol …

    …specification.
    
    - renamed the property "len" to "strLen" to avoid problems in Go
    chrisdutz committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    03c9fdb View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. feat(ads): ADS Auto-Discovery

    First working version that correctly sends out the requests to all valid IPs and then correctly processes the responses
    chrisdutz committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c3d00f5 View commit details
    Browse the repository at this point in the history
  2. feat(ads): ADS Auto-Discovery

    - Switched to using a pre-allocated buffer
    chrisdutz committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    41a19c1 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. feat(ads): ADS Auto-Discovery

    - Made the buffer allocation actually work nicely.
    chrisdutz committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    9a014f4 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/develop' into feature/cdutz/go-a…

    …ds-ng
    
    # Conflicts:
    #	plc4go/internal/ads/Field.go
    #	plc4go/internal/ads/Reader.go
    #	plc4go/internal/ads/Writer.go
    chrisdutz committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    921d4cb View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. feat(protocols): Added a pointer to a possibly interesting protocol s…

    …pecification.
    
    - Got the parsing of data-type and symbol-table working
    - Tweaked the way the endianess is handles.
    chrisdutz committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b138c73 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. refactor(api) PLC4J API refactoring

    - PlcBrowseItem's getChildren is now a Map
    - PlcBrowseRequest now has a executeWithInterceptor method
    - PlcBrowseResponse now supports multiple queries and therefore has:
        - a getQueryNames() method
        - the getResponseCode method was replaced with a getResponseCode(queryName) method
        - the getValues() method was replaced with a getValues(queryName) method
    - PlcField:
        - Removed the getDefaultJavaType() as PlcValueType provides this
        - replaced String getPlcDataType() with PlcValueType getPlcValueType()
        - replaced int getNumberOfElements() with List<ArrayInfo> getArrayInfo()
    - A new type PlcQuery for being the base of Browse queries
    - PlcValueType now provides a default java type for each constant
    
    Protocols:
    - Extended the data-types of the following protocols to allow mapping to the PlcValueTypes of the API module:
        - canopen
        - genericcan
    
    Adjusted the rest of the codebase accordingly.
    chrisdutz committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    87d81b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23f6814 View commit details
    Browse the repository at this point in the history
  3. refactor(api) PLC4Go API refactoring

    - Continued porting the PLC4Go API to be on par with the updated PLC4J API
    - Started porting most of the existing code, but espeically the Browse parts still need quite some work.
    chrisdutz committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    e4527f5 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. refactor(api) PLC4Go API refactoring

    - Finished implementing the multi-level-array-info-parsing
    chrisdutz committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    7368b14 View commit details
    Browse the repository at this point in the history
  2. refactor(api) PLC4Go API refactoring

    - Continued cleaning up the code after the changes.
    chrisdutz committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ba88ccb View commit details
    Browse the repository at this point in the history
  3. refactor(api) PLC4Go API refactoring

    - Continued cleaning up the code after the changes.
    chrisdutz committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c10d47b View commit details
    Browse the repository at this point in the history
  4. refactor(api) PLC4Go API refactoring

    - Continued cleaning up the code after the changes.
    chrisdutz committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    4664e11 View commit details
    Browse the repository at this point in the history
  5. refactor(api) PLC4Go API refactoring

    - Finished cleaning the compilation up
    
    next will be getting the tests back green
    chrisdutz committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    93e5b64 View commit details
    Browse the repository at this point in the history
  6. refactor(api) PLC4Go API refactoring

    - Finished fixing the go tests.
    chrisdutz committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ee321aa View commit details
    Browse the repository at this point in the history
  7. fix(test) Not all tests are executed when enabling the "jenkins-build…

    …" or the "with-all-tests" profiles.
    
    - Got the "all-tests" profile working again.
    chrisdutz committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8e9b4af View commit details
    Browse the repository at this point in the history
  8. fix(test) Not all tests are executed when enabling the "jenkins-build…

    …" or the "with-all-tests" profiles.
    
    - Got the RandomPackagesTest working again
    - Currently commented out the "0-termination" in the ReadBufferByteBased
    - Got the libpcapNg detection working on aarch64 mac
    chrisdutz committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c7aace7 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. fix(test) Fix RandomPackagesTest

    - Changed the ReadBufferByteBased to react on a system property "disable-string-0-termination" to make it work with the 0-terminating byte-buffer.
    chrisdutz committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3a00255 View commit details
    Browse the repository at this point in the history
  2. fix(test) Fix RandomPackagesTest

    - Changed the ReadBufferByteBased to react on a system property "disable-string-0-termination" to make it work with the 0-terminating byte-buffer.
    chrisdutz committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    96726d5 View commit details
    Browse the repository at this point in the history
  3. fix(test) Fix error in WriteBufferByteBased, which output the padding…

    … bytes before the string
    
    -
    chrisdutz committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    803eca2 View commit details
    Browse the repository at this point in the history
  4. fix(test) Fix error in WriteBufferByteBased, which output the padding…

    … bytes before the string
    
    - Removed the disabling of 0-termination in the RandomPackageTest
    - Added some comments on the reading and writing of strings (expected format)
    chrisdutz committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    dd08203 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'origin/develop' into feature/cdutz/go-a…

    …ds-ng
    
    # Conflicts:
    #	plc4go/protocols/bacnetip/readwrite/model/NLMDisconnectConnectionToNetwork.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMEstablishConnectionToNetwork.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMIAmRouterToNetwork.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMICouldBeRouterToNetwork.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMInitalizeRoutingTable.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMInitalizeRoutingTableAck.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMRejectRouterToNetwork.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMRouterAvailableToNetwork.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMRouterBusyToNetwork.go
    #	plc4go/protocols/bacnetip/readwrite/model/NLMWhoIsRouterToNetwork.go
    chrisdutz committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e1a2ab3 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. refactor(api) PLC4J API refactoring

    - Updated the builders to use the new addField and addFieldAddress naming
    chrisdutz committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    558a82a View commit details
    Browse the repository at this point in the history
  2. refactor(api) PLC4J API refactoring

    - Applied Sebasitan's feedback
    chrisdutz committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    dcbfa53 View commit details
    Browse the repository at this point in the history
  3. refactor(api) PLC4J API refactoring

    - Applied Sebasitan's feedback
    chrisdutz committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    cc2216c View commit details
    Browse the repository at this point in the history
  4. refactor(api) PLC4J API refactoring

    - Applied Sebasitan's feedback
    chrisdutz committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a3b5a86 View commit details
    Browse the repository at this point in the history
  5. refactor(api) PLC4J API refactoring

    - Renamed Field -> Tag in PLC4J
    chrisdutz committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    93c84d5 View commit details
    Browse the repository at this point in the history
  6. refactor(api) PLC4J API refactoring

    - Renamed Field -> Tag in PLC4J
    chrisdutz committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    3dd976f View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. refactor(api) PLC4J API refactoring

    - Renamed Field -> Tag in PLC4C
    chrisdutz committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    08933ce View commit details
    Browse the repository at this point in the history
  2. refactor(api) PLC4Go API refactoring

    - Updated generated code for PLC4Go
    chrisdutz committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    a415886 View commit details
    Browse the repository at this point in the history
  3. refactor(api) PLC4J API refactoring

    - Removed getPlcValueType and getArrayInfo from the PlcBrowseItem as this information is in the Tag
    - Removed the PlcBrowseItemArrayInfo type, as this is replaced by ArrayInfo
    chrisdutz committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    39ba084 View commit details
    Browse the repository at this point in the history
  4. refactor(api) PLC4Go API refactoring

    - Continued the refactoring with PLC4Go
    chrisdutz committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    22d38c5 View commit details
    Browse the repository at this point in the history
  5. refactor(api) PLC4Go API refactoring

    - Continued the refactoring with PLC4Go
    chrisdutz committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    6be695d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    11dc603 View commit details
    Browse the repository at this point in the history