adapting some contributions by Axel Richter on StackOverflow #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
pjfanning
reviewed
Sep 25, 2018
| @@ -34,12 +35,27 @@ Licensed to the Apache Software Foundation (ASF) under one or more | |||
| public XDDFBarChartData(CTBarChart chart, Map<Long, XDDFChartAxis> categories, | |||
| Map<Long, XDDFValueAxis> values) { | |||
| this.chart = chart; | |||
| if (chart.getBarDir() == null) { | |||
There was a problem hiding this comment.
could you remove the tabs from your code?
There was a problem hiding this comment.
Thanks for notifying about my IDE running misconfigured!
| @@ -214,6 +214,28 @@ public void setAutoTitleDeleted(boolean deleted) { | |||
| chart.getAutoTitleDeleted().setVal(deleted); | |||
| } | |||
|
|
|||
| public Boolean getTitleOverlay() { | |||
There was a problem hiding this comment.
would it make sense to add @since 4.0.1 to these new methods?
| @@ -99,6 +111,22 @@ protected CTSerTx getSeriesText() { | |||
| return series.getTx(); | |||
| } | |||
|
|
|||
| public Boolean getSmooth() { | |||
There was a problem hiding this comment.
similar question about annotating public methods with the since version
|
closed by r1841988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While searching for more improvement inspiration based on link from https://bz.apache.org/bugzilla/show_bug.cgi?id=62746, I found some great contributions by Axel Richter using low-level
CT*classes that can be adapted to newer API.