Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertiesChunk.writeProperties: no need to write ASCII_STRING properties as UNICODE_STRING #146

Closed
wants to merge 9,840 commits into from
Closed

PropertiesChunk.writeProperties: no need to write ASCII_STRING properties as UNICODE_STRING #146

wants to merge 9,840 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Dec 17, 2018

  1. [bug-63005] disable the reading of DTDs altogether 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849123 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Dec 17, 2018
    Copy the full SHA
    9953339 View commit details
    Browse the repository at this point in the history

  2. lgtm issues: potential index out of bounds exceptions 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849127 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Dec 17, 2018
    Copy the full SHA
    cec45d6 View commit details
    Browse the repository at this point in the history

  3. [bug-63005] ignore openxml4j/ContentTypeHasEntities.ooxml 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849128 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Dec 17, 2018
    Copy the full SHA
    7c26c97 View commit details
    Browse the repository at this point in the history

  4. only refactorings to break up the long method 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849130 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 17, 2018
    Copy the full SHA
    00a7b49 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. [bug-63013] add XWPFRun setLang method 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849152 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Dec 18, 2018
    Copy the full SHA
    04d1627 View commit details
    Browse the repository at this point in the history

  2. [github-137] solves/unifies blank/missing value colection for PRODUCT… 

    …/MDETERM/GEOMEAN. Thanks to gallonfizik. This closes #137

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849237 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Dec 18, 2018
    Copy the full SHA
    fa0066d View commit details
    Browse the repository at this point in the history

  3. #63017 - Remove rows from a XSLFTable 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849244 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 18, 2018
    Copy the full SHA
    337bc9e View commit details
    Browse the repository at this point in the history

  4. #63017 - Remove rows from a XSLFTable 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849248 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 18, 2018
    Copy the full SHA
    5de5b8c View commit details
    Browse the repository at this point in the history

  5. fix index check in HemfDraw 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849250 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Dec 18, 2018
    Copy the full SHA
    c5ca61e View commit details
    Browse the repository at this point in the history

  6. #62886 - Regression extracting text from corrupted docx files 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849252 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 18, 2018
    Copy the full SHA
    bd951d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. Add missing jacoco-lib to test-scratchpad 

    Remove some xmlns that are not needed any more now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849280 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 19, 2018
    Copy the full SHA
    9211380 View commit details
    Browse the repository at this point in the history

  2. One more file-leak-detector exclude 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849286 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 19, 2018
    Copy the full SHA
    c95b62e View commit details
    Browse the repository at this point in the history

  3. Rework test somewhat and enable logger to better indicate if the test is 

    failing because JDK options are missing with JDK >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849287 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 19, 2018
    Copy the full SHA
    d5e2aca View commit details
    Browse the repository at this point in the history

  4. fix old xerces errors because of not available disallow-doctype parse… 

    …r feature

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849336 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 19, 2018
    Copy the full SHA
    deef652 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2018

  1. Add more file-leak exlcudes for the mass regression testing 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849715 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 25, 2018
    Copy the full SHA
    719b102 View commit details
    Browse the repository at this point in the history

  2. Code-style: Unify how arrays are specified from C-style to normal Jav… 

    …a-style

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849716 13f79535-47bb-0310-9956-ffa450edef68
    centic committed Dec 25, 2018
    Copy the full SHA
    2bd8838 View commit details
    Browse the repository at this point in the history

  3. Bug 62884: sheetnum is not checked in InternalWorkbook.setSheetHidden() 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849717 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 25, 2018
    Copy the full SHA
    bf5fad6 View commit details
    Browse the repository at this point in the history

  4. JavaDoc fixes/additions and some IDE warnings removed 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849718 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 25, 2018
    Copy the full SHA
    8e0501a View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2018

  1. Simplify some string operations 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 26, 2018
    Copy the full SHA
    e827a69 View commit details
    Browse the repository at this point in the history

  2. Remove unnecesssary semicolons 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849761 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 26, 2018
    Copy the full SHA
    ee0dc99 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect constant for pict-files 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849762 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 26, 2018
    Copy the full SHA
    3219b3a View commit details
    Browse the repository at this point in the history

  4. Fix various IDE warnings and some JavaDoc adjustments 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849763 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 26, 2018
    Copy the full SHA
    8011fdc View commit details
    Browse the repository at this point in the history

  5. Bug 62839: Adjust MathX.floor() to handle negative values the same 

    way as Excel/LibreOffice

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849764 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 26, 2018
    Copy the full SHA
    0089868 View commit details
    Browse the repository at this point in the history

  6. Add some simple coverage of HSLF-Dev-Tools 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849765 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 26, 2018
    Copy the full SHA
    312baae View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. IDE and JavaDoc fixes, close() in tests 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849812 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 27, 2018
    Copy the full SHA
    480c081 View commit details
    Browse the repository at this point in the history

  2. Re-instate two dev-tools that we lost in some refactoring, 

    at least OOXMLPrettyPrint is still very useful for comparing ooxml-files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849813 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 27, 2018
    Copy the full SHA
    6aafdf2 View commit details
    Browse the repository at this point in the history

  3. Bug 62629: Allow to handle files with invalid content types for pictures 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849814 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 27, 2018
    Copy the full SHA
    e0484ac View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2018

  1. Adjust/enhance tests for bug 62275 some more 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849836 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    9501862 View commit details
    Browse the repository at this point in the history

  2. Adjust test to not require src/documentation to be available 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849837 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    c554aea View commit details
    Browse the repository at this point in the history

  3. Add XMLBeans jobs for JDK 8 and 11. 

    Add initial version of Jenkins DSL for the Github-PullRequest build-job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849838 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    30835c9 View commit details
    Browse the repository at this point in the history

  4. Add test which verifies that bug 61605 is already fixed 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849878 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    691ade8 View commit details
    Browse the repository at this point in the history

  5. Use normal string parameter for now 

    Plugin for gitParam is not installed in the Apache Jenkins instance

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849879 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    3e25837 View commit details
    Browse the repository at this point in the history

  6. Bug 61532: Fix setting values/types during formula evaluation for SXSSF 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849880 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    deeaa07 View commit details
    Browse the repository at this point in the history

  7. Run Cell-tests on HSSF as well and make handling of null-values consi… 

    …stent across implementations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849881 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    e3ce49c View commit details
    Browse the repository at this point in the history

  8. Jenkins DSL: throttle Github PR builds to not run many at once 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849884 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    b60bcec View commit details
    Browse the repository at this point in the history

  9. Jenkins DSL: enable Github PR builds, it seems to be functional now 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849885 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    860ee9f View commit details
    Browse the repository at this point in the history

  10. Jenkins DSL for Github PR build: Try to create the one file which is … 

    …read from src/documentation during target 'jenkins'

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849887 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 28, 2018
    Copy the full SHA
    270b7f3 View commit details
    Browse the repository at this point in the history

  11. Zero out garbage bytes in FontEntityAtom 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849895 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 28, 2018
    Copy the full SHA
    162d14f View commit details
    Browse the repository at this point in the history

  12. Fix Javadocs 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849896 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 28, 2018
    Copy the full SHA
    cf1e15b View commit details
    Browse the repository at this point in the history

  13. Add Enum method to help identifying unknown records with POI-Visualizer 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849897 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 28, 2018
    Copy the full SHA
    7416a82 View commit details
    Browse the repository at this point in the history

  14. #63028 - Provide font embedding for slideshows 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849898 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 28, 2018
    Copy the full SHA
    033c092 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. IDE and JavaDoc fixes, make base test classes abstract 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849968 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 30, 2018
    Copy the full SHA
    fe44bd2 View commit details
    Browse the repository at this point in the history

  2. Bug 60845: Apply patch and adjust tests 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849969 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 30, 2018
    Copy the full SHA
    9167737 View commit details
    Browse the repository at this point in the history

  3. Jenkins DSL: Disable XMLBeans-JDK-11 as it will not work yet 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849970 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 30, 2018
    Copy the full SHA
    cafe763 View commit details
    Browse the repository at this point in the history

  4. IDE and JavaDoc fixes 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850007 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 30, 2018
    Copy the full SHA
    c8c441c View commit details
    Browse the repository at this point in the history

  5. Bug 60460: Handle null workbook or sheet names and emit #REF as Excel… 

    … does

instead of throwing NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850008 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 30, 2018
    Copy the full SHA
    0524654 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2018

  1. Adjust test for bug 60460 to also run fine on Windows 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850022 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Dec 31, 2018
    Copy the full SHA
    d4539d9 View commit details
    Browse the repository at this point in the history

  2. #63047 - Make POILogger subclassable 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850040 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 31, 2018
    Copy the full SHA
    8db6684 View commit details
    Browse the repository at this point in the history

  3. exclude integrationtest/build from rat-check 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850041 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Dec 31, 2018
    Copy the full SHA
    2a2804a View commit details
    Browse the repository at this point in the history

  4. fix since annotation 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850048 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Dec 31, 2018
    Copy the full SHA
    cdbda8e View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2019

  1. Add missing file-close in ZipInputStreamZipEntrySource seen in some m… 

    …ass regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850114 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 1, 2019
    Copy the full SHA
    b7d5591 View commit details
    Browse the repository at this point in the history

  2. Add missing revert() in OPCPackage to close Zip-streams always 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850115 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 1, 2019
    Copy the full SHA
    cc760d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. Bug 62307: made Cell#getNumericCellValue() behavior consistent across… 

    … HSSF/XSSF/SXSSF.\nAll three implementations throw ISE when trying to get numeric value from a boolean-valued cell, have it a formula set or not.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850207 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 2, 2019
    Copy the full SHA
    42261c8 View commit details
    Browse the repository at this point in the history

  2. Bug 62828: CellReference(Cell) now initializes sheet name. 

    Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 2, 2019
    Copy the full SHA
    c86ae2c View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Bug 62993: XSSFEvaluationSheet now retrieves valid last row index fro… 

    …m underlying XSSFSheet. Thanks to Axel Howind.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 3, 2019
    Copy the full SHA
    217633f View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. Improved test coverage for *Cell classes 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850338 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 4, 2019
    Copy the full SHA
    2cda553 View commit details
    Browse the repository at this point in the history

  2. Bug 63057: made SXSSFCell.setCellValue(String|RichTextString) excepti… 

    …on-safe.

Also removed unused code.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850342 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 4, 2019
    Copy the full SHA
    e168859 View commit details
    Browse the repository at this point in the history

  3. Fixed build (explicitly specified charset for new String(byte[])) 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850366 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 4, 2019
    Copy the full SHA
    7ca850e View commit details
    Browse the repository at this point in the history

  4. throw IllegalArgumnetException if null directory specified 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850394 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Jan 4, 2019
    Copy the full SHA
    09ac35e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2019

  1. updated mockito to 2.23.4 to fix java 11 build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850590 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 6, 2019
    Copy the full SHA
    933a546 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2019

  1. Bug 62904: Support array arguments in IF and logical IS*** functions 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850646 13f79535-47bb-0310-9956-ffa450edef68
    Yegor Kozlov committed Jan 7, 2019
    Copy the full SHA
    73085f9 View commit details
    Browse the repository at this point in the history

  2. unified setCellType(null/_NONE) logic, setCellFormula(null) logic. up… 

    …dated javadoc and tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 7, 2019
    Copy the full SHA
    7b44d1e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2019

  1. Bug 63054: improved evaluation of array formulas with error in arguments 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850742 13f79535-47bb-0310-9956-ffa450edef68
    Yegor Kozlov committed Jan 8, 2019
    Copy the full SHA
    bc95663 View commit details
    Browse the repository at this point in the history

  2. Bug 63054: updated formulas in test spreadsheet to keep build happy 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850772 13f79535-47bb-0310-9956-ffa450edef68
    Yegor Kozlov committed Jan 8, 2019
    Copy the full SHA
    0731deb View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2019

  1. use spaces for indents 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850926 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Jan 10, 2019
    Copy the full SHA
    4c632eb View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. Bug #60977 writing XSSF with custom properties twice corrupts output 

    turns out the output XML data buffer for the custom properties document was appended to, not replaced, when writing in the presence of existing content.  Now clearing output buffer first in this case.  When first creating custom properties, i.e. first write after changes, there is no buffer yet, so nothing to clear.

Does not affect any read operations, or other writes beyond custom properties, as that was where the problem lay, not down in the Zip stuff.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851084 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Jan 11, 2019
    Copy the full SHA
    e211bfc View commit details
    Browse the repository at this point in the history

  2. Add one more test for bug 62828 and fix some IDE warnings 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851088 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 11, 2019
    Copy the full SHA
    e80e47c View commit details
    Browse the repository at this point in the history

  3. IDE and JavaDoc fixes, move/remove some unfixed tests 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851089 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 11, 2019
    Copy the full SHA
    30de7f7 View commit details
    Browse the repository at this point in the history

  4. Enable weekly run of Java 12 build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851090 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 11, 2019
    Copy the full SHA
    685992f View commit details
    Browse the repository at this point in the history

  5. Remove obsolete settings from JDK 11/12 build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851091 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 11, 2019
    Copy the full SHA
    cac99fe View commit details
    Browse the repository at this point in the history

  6. Revert inadvertently commented lines 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851092 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 11, 2019
    Copy the full SHA
    bb2597b View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2019

  1. Add reproducer for bug 60355 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851208 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 13, 2019
    Copy the full SHA
    6c7df04 View commit details
    Browse the repository at this point in the history

  2. Bug 62810: AreaReference ctor looses sheet name if rows or columns sw… 

    …apped

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851209 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 13, 2019
    Copy the full SHA
    68c1dcc View commit details
    Browse the repository at this point in the history

  3. Fix some Findbugs and IDE issues, refactor some duplicated code, 

    improve some exception texts, add comment for missing Ptg for SxName

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 13, 2019
    Copy the full SHA
    3b20c94 View commit details
    Browse the repository at this point in the history

  4. Don't fail on row-nums larger than Integer.MAX_VALUE, we had one sample 

    file which triggered this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851211 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 13, 2019
    Copy the full SHA
    57b38a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. follow-up to Bug 62904. More tests and improved evaluation of IF in a… 

    …rray mode

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851263 13f79535-47bb-0310-9956-ffa450edef68
    Yegor Kozlov committed Jan 14, 2019
    Copy the full SHA
    9c58649 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. [github-140] add .travis.yml. Thanks to krichter722. This closes #140 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851312 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Jan 15, 2019
    Copy the full SHA
    ef4175f View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. update xmlbeans targets 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851657 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Jan 18, 2019
    Copy the full SHA
    75913df View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. try to fix xmlbeans build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851667 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Jan 19, 2019
    Copy the full SHA
    ed8e341 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Fix some IDE warnings and JVM deprecations 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851795 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 22, 2019
    Copy the full SHA
    37c6577 View commit details
    Browse the repository at this point in the history

  2. Fix passing in --add-opens for Java 9+ after the poiunit refactoring,… 

    … this

only caused problems with Java 9+ on Windows, which we do not run in CI (yet)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851796 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 22, 2019
    Copy the full SHA
    ff1e89e View commit details
    Browse the repository at this point in the history

  3. Fix invalid comment in build.xml 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851797 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 22, 2019
    Copy the full SHA
    873beb6 View commit details
    Browse the repository at this point in the history

  4. Jenkins: Add initial build for JDK 13, add build for JDK 12 on Windows 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851798 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 22, 2019
    Copy the full SHA
    5d77359 View commit details
    Browse the repository at this point in the history

  5. Jenkins: Try to disable coverage for JDK 13 for now as it seems to ca… 

    …use issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851803 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 22, 2019
    Copy the full SHA
    67cbedf View commit details
    Browse the repository at this point in the history

  6. Add required --add-opens and other settings for JDK 12 on Windows 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851804 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 22, 2019
    Copy the full SHA
    f7dfe49 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. try to fix missing modules error and move addOpens detection into ant… 

    … build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852072 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Jan 24, 2019
    Copy the full SHA
    8e59b70 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. setCellFormula: blank cell gets value 0, non-blank value is preserved 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852212 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    4b61d7f View commit details
    Browse the repository at this point in the history

  2. added Cell.setBlank() - as an alias, for now 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852244 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    431e195 View commit details
    Browse the repository at this point in the history

  3. purged calls to cell.setCellType(CellType.BLANK) from the project, re… 

    …placed with setBlank()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852245 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    0993397 View commit details
    Browse the repository at this point in the history

  4. made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cel… 

    …l.setCellType(). Purged all redundant calls from project.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    c8d0b7c View commit details
    Browse the repository at this point in the history

  5. purged usages of Cell.setCellType (left only in tests, where conversi… 

    …ons are tested)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    7f3d575 View commit details
    Browse the repository at this point in the history

  6. pulled *Cell.getAddress to common base 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    ed321b0 View commit details
    Browse the repository at this point in the history

  7. pulled *Cell.getCellTypeEnum() to common base 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    02d0fbb View commit details
    Browse the repository at this point in the history

  8. pulled *Cell.setCellValue(double) to the common base 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852253 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    0f2845b View commit details
    Browse the repository at this point in the history

  9. pulled *Cell.setCellValue(Date) and setCellValue(Calendar) to the com… 

    …mon base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852254 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    0061197 View commit details
    Browse the repository at this point in the history

  10. pulled *Cell.setCellValue(String), setCellValue(RichTextString) to th… 

    …e common base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852255 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 26, 2019
    Copy the full SHA
    30096c1 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2019

  1. Ignore file-leaks from openjpa/derby/log4j for the regression tests 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852276 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 27, 2019
    Copy the full SHA
    648d6be View commit details
    Browse the repository at this point in the history

  2. Bug 60405: Add initial support for cetab functions so some macros can be 

    parsed
Add some function-definitions for Excel 4 Macros and missing functions
found in regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852277 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 27, 2019
    Copy the full SHA
    b6a313f View commit details
    Browse the repository at this point in the history

  3. Adjust handling of some exceptions in regression tests 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852278 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 27, 2019
    Copy the full SHA
    b5a0747 View commit details
    Browse the repository at this point in the history

  4. Exclude one more local file from rat-checks 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852279 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 27, 2019
    Copy the full SHA
    9f1130e View commit details
    Browse the repository at this point in the history

  5. Fix some IDE warnings and better output in unit test 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852280 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 27, 2019
    Copy the full SHA
    8c2e0a1 View commit details
    Browse the repository at this point in the history

  6. Add reproducing test-case for a bug we found newly introduced in JDK … 

    …12-ea+28

and fixed again in JDK 12-ea+29

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852281 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 27, 2019
    Copy the full SHA
    0dd04de View commit details
    Browse the repository at this point in the history

  7. removed accidentally added release-notes 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852283 13f79535-47bb-0310-9956-ffa450edef68
    Vladislav Galas committed Jan 27, 2019
    Copy the full SHA
    ea00bb7 View commit details
    Browse the repository at this point in the history

  8. Jenkins DSL: Adjust the list of JDKs that we look for in the testevn-job 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852284 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 27, 2019
    Copy the full SHA
    640e891 View commit details
    Browse the repository at this point in the history

  9. remove new documentation directory and then ... 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852299 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Jan 27, 2019
    Copy the full SHA
    09f8aba View commit details
    Browse the repository at this point in the history

  10. ... link external again 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852300 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Jan 27, 2019
    Copy the full SHA
    cd2b293 View commit details
    Browse the repository at this point in the history

  11. Jenkins DSL: Add more output in test-env-build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852309 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Jan 27, 2019
    Copy the full SHA
    241b0f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2019

  1. Bug 62980: Make D* functions ignore case in headings 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853268 13f79535-47bb-0310-9956-ffa450edef68
    yegor committed Feb 9, 2019
    Copy the full SHA
    61931b2 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Bug 63029: OPCPackage Potentially clobbers files on close() 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853454 13f79535-47bb-0310-9956-ffa450edef68
    yegor committed Feb 12, 2019
    Copy the full SHA
    7950b92 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Bug 63029: revert handling NotOfficeXmlFileException in ZipPackage as… 

    … this change broke the build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853474 13f79535-47bb-0310-9956-ffa450edef68
    yegor committed Feb 13, 2019
    Copy the full SHA
    9bba7be View commit details
    Browse the repository at this point in the history

  2. Bug 63029: fixed failing test in test-ooxml-lite 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853523 13f79535-47bb-0310-9956-ffa450edef68
    yegor committed Feb 13, 2019
    Copy the full SHA
    2a7045c View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. [bug-63187] fix typos 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853787 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Feb 18, 2019
    Copy the full SHA
    069b4ef View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2019

  1. [bug-63151] handle NPE in UnicodeString 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853859 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Feb 19, 2019
    Copy the full SHA
    ecaa490 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. Bug 60980: Fix parsing formulas with intersections in functions args 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854037 13f79535-47bb-0310-9956-ffa450edef68
    Yegor Kozlov committed Feb 21, 2019
    Copy the full SHA
    720f352 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. Adjust BaseIntegrationTest some more to better handle invalid file ex… 

    …tensions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854189 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Feb 23, 2019
    Copy the full SHA
    0c00c84 View commit details
    Browse the repository at this point in the history

  2. Add some more testing for bug 63151: NullPointerException in HSSFOpti… 

    …miser.optimiseFonts(), also execute it as part of large regression tests in the future

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854190 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Feb 23, 2019
    Copy the full SHA
    da8d4c9 View commit details
    Browse the repository at this point in the history

  3. Remove some remnants of NFileSystem 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854191 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Feb 23, 2019
    Copy the full SHA
    fa51e96 View commit details
    Browse the repository at this point in the history

  4. Close file-handles for slideshows also when construction fails or whe… 

    …n dual-storage is used

Also avoid file-leak reports in some tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854192 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Feb 23, 2019
    Copy the full SHA
    53f980a View commit details
    Browse the repository at this point in the history

  5. Add batik-jars to findbugs-task 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854193 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Feb 23, 2019
    Copy the full SHA
    ecdf59c View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2019

  1. Fix detecting Java <= 8 vs. >= 9 to not detect Java 8 for version-str… 

    …ing "11.x"

Add system property to junit to disable optimization in jaxb which causes illegal access in Java 9+
Add argument to junit to display all illegal accesses in Java 9+

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854629 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 2, 2019
    Copy the full SHA
    27e353b View commit details
    Browse the repository at this point in the history

  2. Bug 62151: Fix warnings about illegal reflective access in Java 9+ by 

    using a similar approach as Apache Hadoop via a CleanerUtil class which encapsulates
the two different approaches for Java <= 8 and Java >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854630 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 2, 2019
    Copy the full SHA
    5bd5d8b View commit details
    Browse the repository at this point in the history

  3. Bug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and … 

    …check some more in integration tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854639 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 2, 2019
    Copy the full SHA
    e98594e View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2019

  1. Fix a regression test failure, toString() should never return null 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854717 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 3, 2019
    Copy the full SHA
    1996575 View commit details
    Browse the repository at this point in the history

  2. Close more file-handles in tests 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854718 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 3, 2019
    Copy the full SHA
    9ccd993 View commit details
    Browse the repository at this point in the history

  3. Update file-leak excludes for XMLBeans/jaxb 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854719 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 3, 2019
    Copy the full SHA
    33f9651 View commit details
    Browse the repository at this point in the history

  4. Jenkins DSL: Add XMLBeans-JDK-12, still disabled, though 

    Print out where we get Ant from
Use new 'jenkins' target for XMLBeans and fetch compiler warnings and JUnit results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854720 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 3, 2019
    Copy the full SHA
    5f77499 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. [bug-63240] make DocumentHelper.newDocumentBuilder non-synchronized] 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854935 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 6, 2019
    Copy the full SHA
    d106aac View commit details
    Browse the repository at this point in the history

  2. [bug-63240] make SAXHelper.newXMLReader non-synchronized] 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854941 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 6, 2019
    Copy the full SHA
    1b61d43 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2019

  1. Jenkins DSL: Enable job for running API-Check again now that we compa… 

    …re 4.x to 4.0.0

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855138 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 10, 2019
    Copy the full SHA
    58eb59e View commit details
    Browse the repository at this point in the history

  2. Adjust test to not fail with Xerces XML Parser, fix some IDE warnings 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855139 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 10, 2019
    Copy the full SHA
    0bf0822 View commit details
    Browse the repository at this point in the history

  3. Bug 63221: Add margin-settings for top, bottom, left and right to XSS… 

    …FPrintSetup

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855154 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 10, 2019
    Copy the full SHA
    6ce3da3 View commit details
    Browse the repository at this point in the history

  4. Fix URL for test 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855155 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 10, 2019
    Copy the full SHA
    83381a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. fix some cases where iterator usage does not check hasNext 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 14, 2019
    Copy the full SHA
    485769c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. #63264 Conditional Format rule evaluation calculates relative referen… 

    …ces incorrectly

Fixing the offset calculation and passing the top-left-most region rather than the region matching the current cell fixed these cases.  I've augmented unit tests to check for them to avoid future regressions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855619 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 16, 2019
    Copy the full SHA
    fa697d6 View commit details
    Browse the repository at this point in the history

  2. Handle possible invalid date value (#61652) 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855627 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 16, 2019
    Copy the full SHA
    1d252c7 View commit details
    Browse the repository at this point in the history

  3. Bug 61472: Convert date/time strings to numbers when evaluating formulas 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855662 13f79535-47bb-0310-9956-ffa450edef68
    Yegor Kozlov committed Mar 16, 2019
    Copy the full SHA
    5d325eb View commit details
    Browse the repository at this point in the history

  4. Use JPG source, otherwise we have problems with Alpha conversion in O… 

    …penJDK.

https://stackoverflow.com/questions/3432388/imageio-not-able-to-write-a-jpeg-file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855668 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Mar 16, 2019
    Copy the full SHA
    1d4673b View commit details
    Browse the repository at this point in the history

  5. Fix forbidden apis error 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855672 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Mar 16, 2019
    Copy the full SHA
    d7c5977 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. #60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' v… 

    …ariations

The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.

Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.

Added unit test cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 18, 2019
    Copy the full SHA
    6f57530 View commit details
    Browse the repository at this point in the history

  2. Fix a unit test that changed with the implementation of another funct… 

    …ion.

Didn't fail for me because I hadn't noticed the Eclipse classpath was out of date wrt some dependency versions, and therefore my local code was not compiling properly, meaning my test run ran old code and passed this one when it should have failed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855792 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 18, 2019
    Copy the full SHA
    37b3ed0 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. pre-release maintenance: 

    * add my key to the KEYS file
* update year in NOTICE (first release of 2019)
* remove svn:executable flag from random test data files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855799 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 19, 2019
    Copy the full SHA
    d22647b View commit details
    Browse the repository at this point in the history

  2. [bug-63268] fix issue where CellUtil.setFont is adding unnecessary st… 

    …yles

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855806 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 19, 2019
    Copy the full SHA
    74adb9c View commit details
    Browse the repository at this point in the history

  3. Remove more remnants of NPOIFSFileSystem, mostly in comments and vari… 

    …able names

This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 19, 2019
    Copy the full SHA
    721ab0e View commit details
    Browse the repository at this point in the history

  4. Switch to parameterized test and add some more information to try to … 

    …find

out why this test fails from time to time

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855874 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 19, 2019
    Copy the full SHA
    6af0c20 View commit details
    Browse the repository at this point in the history

  5. Remove old versions of commons-collections also in ooxml-lib, we loaded 

    it there at some point

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855875 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 19, 2019
    Copy the full SHA
    3a3be2e View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. use xmlbeans-3.0.3 rc version 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855952 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 20, 2019
    Copy the full SHA
    8fbab64 View commit details
    Browse the repository at this point in the history

  2. some javadoc issues 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855954 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 20, 2019
    Copy the full SHA
    402267c View commit details
    Browse the repository at this point in the history

  3. remove unncessary synchronization 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855956 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 20, 2019
    Copy the full SHA
    854820c View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. possible npe in test 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855969 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    416bc18 View commit details
    Browse the repository at this point in the history

  2. try to fix gradle build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855970 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    630e702 View commit details
    Browse the repository at this point in the history

  3. try to fix gradle build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855971 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    122ca01 View commit details
    Browse the repository at this point in the history

  4. try to fix gradle build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855972 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    1189f08 View commit details
    Browse the repository at this point in the history

  5. commons-collections4 - 4.3 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855973 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    6314b46 View commit details
    Browse the repository at this point in the history

  6. commons-codec - 1.12 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855975 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    82c1cb0 View commit details
    Browse the repository at this point in the history

  7. upgrade bouncycastle and curvesapi 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855978 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    4a67dcc View commit details
    Browse the repository at this point in the history

  8. upgrade xmlsec, slf4j, batik 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855990 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    65994bc View commit details
    Browse the repository at this point in the history

  9. reorder jar files 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855994 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    4672f72 View commit details
    Browse the repository at this point in the history

  10. reorder jar files 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855995 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 21, 2019
    Copy the full SHA
    06eb321 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. [github-142] issue in ExcelComparator example. Thanks to chirkovmail.… 

    … This close #142

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856053 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 22, 2019
    2
    Copy the full SHA
    709c332 View commit details
    Browse the repository at this point in the history

  2. xmlbeans 3.1.0 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856093 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 22, 2019
    Copy the full SHA
    351623a View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. use released version of xmlbeans 3.1.0 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856354 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 26, 2019
    Copy the full SHA
    d63c608 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. add test for concurrent use of DataFormatter 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856439 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 27, 2019
    Copy the full SHA
    ee5fa41 View commit details
    Browse the repository at this point in the history

  2. [bug-63291] support concurrent date formatting with same DataFormatter 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856449 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 27, 2019
    Copy the full SHA
    cd74839 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2019

  1. #63302 Formula evaluation of names with offset or row function is inc… 

    …orrect

thanks to John Lincoln White for the patch, including new unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856644 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 30, 2019
    Copy the full SHA
    95fe97b View commit details
    Browse the repository at this point in the history

  2. #63291 CellFormat global cache isn't thread-safe 

    move date format synchronization down to where the problem instance is held. 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856647 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 30, 2019
    Copy the full SHA
    b18a3aa View commit details
    Browse the repository at this point in the history

  3. #63292 1904 date windowing flag not used for some format cases 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856648 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 30, 2019
    Copy the full SHA
    1dfee69 View commit details
    Browse the repository at this point in the history

  4. fix build issue 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856649 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 30, 2019
    Copy the full SHA
    bce68be View commit details
    Browse the repository at this point in the history

  5. [bug-61700] getForceFormulaRecalculation() returns wrong value. Fix t… 

    …hanks to Kai G

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856650 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 30, 2019
    Copy the full SHA
    53356ce View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2019

  1. #61700 getForceFormulaRecalculation() returns wrong value 

    changed to use the proper OOXML attribute instead of a hack about calculation engine version ID.  Reporter was right, the behavior was wrong in some cases, but it turns out the fix was a bit more.  See issue for details.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856652 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 31, 2019
    Copy the full SHA
    4a8581d View commit details
    Browse the repository at this point in the history

  2. fix unit test that I merged wrong. 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856653 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 31, 2019
    Copy the full SHA
    3bc56aa View commit details
    Browse the repository at this point in the history

  3. fix a condition not seen until a recent expansion of the stress test.… 

    … Gracefully ignore missing/invalid external sheet references in one more path (there were several already with comments like "this seems to be what Excel does in this case")

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856655 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Mar 31, 2019
    Copy the full SHA
    c776ad7 View commit details
    Browse the repository at this point in the history

  4. replace version number 4.0.2 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856665 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Mar 31, 2019
    Copy the full SHA
    ff11d15 View commit details
    Browse the repository at this point in the history

  5. Close more file-handles in tests, convert junit3 tests 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856688 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 31, 2019
    Copy the full SHA
    0038bf9 View commit details
    Browse the repository at this point in the history

  6. Add some more variants of HTML with preceding newline which we see fr… 

    …equently

in the large regression test corpus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856689 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 31, 2019
    Copy the full SHA
    5e39979 View commit details
    Browse the repository at this point in the history

  7. Add integration-test-jar to jenkins target 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856690 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 31, 2019
    Copy the full SHA
    a2724f3 View commit details
    Browse the repository at this point in the history

  8. Fix some IDE warnings and enable commented test 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856691 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Mar 31, 2019
    Copy the full SHA
    a24ad2b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. Update pentaho repo domain, per 

    https://repo.pentaho.org/

- converted to nexus.pentaho.org

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856966 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 4, 2019
    Copy the full SHA
    d6ee857 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. prepare for 4.1.1 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856983 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 5, 2019
    Copy the full SHA
    0d8c0a1 View commit details
    Browse the repository at this point in the history

  2. revert signing BouncyCastle to 1.51 due to commons-openpgp dependency… 

    … compatibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856984 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 5, 2019
    Copy the full SHA
    3ab465d View commit details
    Browse the repository at this point in the history

  3. try to fix javadoc issues 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856994 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 5, 2019
    Copy the full SHA
    ee1aeba View commit details
    Browse the repository at this point in the history

  4. fix ref to batik version 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856995 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 5, 2019
    Copy the full SHA
    7cf0329 View commit details
    Browse the repository at this point in the history

  5. restore BouncyCastle version to 1.61, update commons-openpgp link to … 

    …newer version for signature tasks.

Should restore build.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857015 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 5, 2019
    Copy the full SHA
    87de739 View commit details
    Browse the repository at this point in the history

  6. release prepare for 4.1.0 - updating build.xml and changes.xml 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857020 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 5, 2019
    Copy the full SHA
    14518d2 View commit details
    Browse the repository at this point in the history

  7. prepare for 4.1.1 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857022 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 5, 2019
    Copy the full SHA
    bbd08f5 View commit details
    Browse the repository at this point in the history

  8. release prepare for 4.1.0 - updating build.xml and changes.xml 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857040 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 5, 2019
    Copy the full SHA
    31634f7 View commit details
    Browse the repository at this point in the history

  9. prepare for 4.1.1 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857042 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 5, 2019
    Copy the full SHA
    3a8f799 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2019

  1. Close more file-handles in tests and convert some more tests to junit-4 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857066 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 7, 2019
    Copy the full SHA
    4da06bf View commit details
    Browse the repository at this point in the history

  2. Improve error message slightly and verify error when a File is passed in 

    as "Object"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857067 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 7, 2019
    Copy the full SHA
    118c4a4 View commit details
    Browse the repository at this point in the history

  3. Fix a flaky test, it seems if the document is not closed, the automatic 

    closing of file-handles interferes with subsequent tests, by closing the
document this flakiness seems to be gone.

Flakiness could be reproduced locally by continuously running test with IntelliJ
"run until failure" run-config option and after aprox. 17,000 test-executions!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857068 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 7, 2019
    Copy the full SHA
    1717938 View commit details
    Browse the repository at this point in the history

  4. Various enhancements to build.xml 

    * Use https for pentaho repository location
* Add some more targets to "jenkins" target
* Add download of maven-ant-task to make target "maven-install"
  work without manual installation into the ant-home directory
* Update JaCoCo to 0.8.3 and asm to 7.0
  This should now also work with JDK 13 pre-builds, so enable
  coverage in the JDK 13 CI builds again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857069 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 7, 2019
    Copy the full SHA
    2f9bbcc View commit details
    Browse the repository at this point in the history

  5. Set version to 4.1.1-SNAPSHOT everywhere to not mix intermediate pack… 

    …ages with the future final ones, add a helper target to set the version from the build.xml everywhere

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857070 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 7, 2019
    Copy the full SHA
    ea45590 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. Bug 63323 -- improve handling of multibyte characters 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857135 13f79535-47bb-0310-9956-ffa450edef68
    @tballison
    tballison committed Apr 8, 2019
    Copy the full SHA
    63ade61 View commit details
    Browse the repository at this point in the history

  2. bug 63327 allow retrieval of wmf data embedded in emf 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857136 13f79535-47bb-0310-9956-ffa450edef68
    @tballison
    tballison committed Apr 8, 2019
    Copy the full SHA
    98ceb1f View commit details
    Browse the repository at this point in the history

  3. Remove invalid import 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857141 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Apr 8, 2019
    Copy the full SHA
    3da0a56 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Update site source for 4.1.0, prep build for 4.1.1 (via ant task) 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857217 13f79535-47bb-0310-9956-ffa450edef68
    Greg Woolsey committed Apr 9, 2019
    Copy the full SHA
    56afa17 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. Bug 63330 -- use skipfully instead of hoping skip() works 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857277 13f79535-47bb-0310-9956-ffa450edef68
    @tballison
    tballison committed Apr 10, 2019
    Copy the full SHA
    f3dafda View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2019

  1. Jenkins: Disable one node which is missing the "svn" command 

    display if svn is available as part of the Test-Environment job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857449 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 13, 2019
    Copy the full SHA
    cb9032e View commit details
    Browse the repository at this point in the history

  2. adjust formatting 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857452 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 13, 2019
    Copy the full SHA
    712ec21 View commit details
    Browse the repository at this point in the history

  3. [bug-63344] add TempFilePOIFSFileSystem 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857461 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 13, 2019
    Copy the full SHA
    e8b5f8b View commit details
    Browse the repository at this point in the history

  4. [bug-63344] add TempFilePOIFSFileSystem 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857462 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 13, 2019
    Copy the full SHA
    79d2246 View commit details
    Browse the repository at this point in the history

  5. Try to make dependency on "svn" optional to allow to build on more CI… 

    … nodes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857476 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 13, 2019
    Copy the full SHA
    bbad8e6 View commit details
    Browse the repository at this point in the history

  6. Add missing license header 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857483 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 13, 2019
    Copy the full SHA
    004570b View commit details
    Browse the repository at this point in the history

  7. Disable all apache-beam-* nodes as they seem to lack svn and Ant inst… 

    …allations currently

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857490 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 13, 2019
    Copy the full SHA
    89347e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. use ArithmeticUtils for calculations that might overflow 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857594 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 15, 2019
    Copy the full SHA
    296c91c View commit details
    Browse the repository at this point in the history

  2. use ArithmeticUtils for calculations that might overflow 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857596 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 15, 2019
    Copy the full SHA
    2b3cad4 View commit details
    Browse the repository at this point in the history

  3. some more checks for int overflows 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857609 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 15, 2019
    Copy the full SHA
    8b903b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. try a different url for svnclient jar (due to broken CI builds) 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857637 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 16, 2019
    Copy the full SHA
    6efa825 View commit details
    Browse the repository at this point in the history

  2. #54803 - Error opening XLSX after saving with a Drawing using POI 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857663 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Apr 16, 2019
    Copy the full SHA
    53d5c2d View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. #54803 - Error opening XLSX after saving with a Drawing using POI 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857671 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Apr 17, 2019
    Copy the full SHA
    1d3ee46 View commit details
    Browse the repository at this point in the history

  2. #github-143 - MAPIType.isFixedLength: not true in case of length > 8 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857708 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed Apr 17, 2019
    Copy the full SHA
    56f7184 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2019

  1. Jenkins DSL: Switch to "Ant 1.9 (Latest)" as "Ant 1.9.9" seems to be … 

    …unavailable on some machines

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857969 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 22, 2019
    Copy the full SHA
    6e23026 View commit details
    Browse the repository at this point in the history

  2. Jenkins DSL: Exclude more beam* nodes which cause strange problems 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857970 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 22, 2019
    Copy the full SHA
    77283a9 View commit details
    Browse the repository at this point in the history

  3. Use https in build.xml where possible to avoid errors in Gradle build 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857971 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 22, 2019
    Copy the full SHA
    cbf4649 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Bug 63073: Adjust returned index of merged regions and verify all cal… 

    …ls in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858021 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 23, 2019
    Copy the full SHA
    ded6e6a View commit details
    Browse the repository at this point in the history

  2. Bug 63371: addMergedRegion does not update CTMergeCells.getCount 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858022 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 23, 2019
    Copy the full SHA
    6a4afb2 View commit details
    Browse the repository at this point in the history

  3. Update JAXB to the latest version 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858023 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 23, 2019
    Copy the full SHA
    0840d54 View commit details
    Browse the repository at this point in the history

  4. Close more file-handles in tests 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858024 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 23, 2019
    Copy the full SHA
    28df7db View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Make compilation work in Eclipse 2019.03 again by working around a 

    limitation of the Eclipse Java Compiler regarding casting/generics

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858117 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed Apr 25, 2019
    Copy the full SHA
    307348d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. [bug-62906] ensure table display name is always set 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858179 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed Apr 26, 2019
    Copy the full SHA
    1b4ea32 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Bug 60656 - EMF image support in slideshows 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858625 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed May 4, 2019
    Copy the full SHA
    81041c3 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2019

  1. Bug 60656 - EMF image support in slideshows 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858628 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed May 5, 2019
    Copy the full SHA
    246f6bc View commit details
    Browse the repository at this point in the history

  2. Disable all beam nodes - ANT is not installed on them 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858660 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed May 5, 2019
    Copy the full SHA
    3c04e91 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2019

  1. [bug-63404] add description to assemble target 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858773 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed May 6, 2019
    Copy the full SHA
    d06f322 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Don't fallback to master shape properties, if master shape is not ass… 

    …igned

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859101 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed May 10, 2019
    Copy the full SHA
    9b525f6 View commit details
    Browse the repository at this point in the history

  2. #59004 - HSLF rendering - adjust values for presetShapeDefinition dif… 

    …fers in HSLF/XSLF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859102 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed May 10, 2019
    Copy the full SHA
    0bdae1a View commit details
    Browse the repository at this point in the history

Commits on May 12, 2019

  1. Bug 60656 - EMF image support in slideshows 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859159 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed May 12, 2019
    Copy the full SHA
    f2d7bd1 View commit details
    Browse the repository at this point in the history

  2. [github-145] issue in PackagingURIHelper.encode. Thanks to @greedbell.… 

    … This closes #145

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859160 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed May 12, 2019
    Copy the full SHA
    a805c30 View commit details
    Browse the repository at this point in the history

  3. exclude H27 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859162 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed May 12, 2019
    Copy the full SHA
    3f78c04 View commit details
    Browse the repository at this point in the history

  4. revert exclude H27 / don't complain on mkdir 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859163 13f79535-47bb-0310-9956-ffa450edef68
    @kiwiwings
    kiwiwings committed May 12, 2019
    Copy the full SHA
    0d045c5 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. [github-148] update license text in pom file. Thanks to Vincent Priva… 

    …t. This close #148

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859202 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed May 14, 2019
    Copy the full SHA
    c27fa22 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. Bug 63431 -- unbug ChunkedCipherInputStream's read() 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859251 13f79535-47bb-0310-9956-ffa450edef68
    @tballison
    tballison committed May 15, 2019
    Copy the full SHA
    0c7afff View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Refine JavaDoc of WorkbookFactory slightly 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859368 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed May 16, 2019
    Copy the full SHA
    c233158 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. FileMagic now has patterns with up to 12 bytes (JPG) 

    Avoid exception if a very short file is encountered
Add more tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859564 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed May 20, 2019
    Copy the full SHA
    52be9c9 View commit details
    Browse the repository at this point in the history

  2. Include actual found type in exception when encountering unexpected t… 

    …ype of file in ExtractorFactory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859565 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed May 20, 2019
    Copy the full SHA
    3dbf8df View commit details
    Browse the repository at this point in the history

  3. Use TempFile to avoid problems with temporary directories in Maven bu… 

    …ilds

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859575 13f79535-47bb-0310-9956-ffa450edef68
    @centic9
    centic9 committed May 20, 2019
    Copy the full SHA
    a25bff9 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Added more chart supports. 

    fixed bug while creating chart with bar and line series.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859589 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    27c37d6 View commit details
    Browse the repository at this point in the history

  2. code cleanup plus fix for bug 63153 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859590 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    ee81606 View commit details
    Browse the repository at this point in the history

  3. fix potential input resource leaks (LGTM) 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859591 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    0e541eb View commit details
    Browse the repository at this point in the history

  4. fix potential output resource leaks (LGTM) 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859592 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    3f49c45 View commit details
    Browse the repository at this point in the history

  5. fix boxed variable is never null 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859593 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    8ccac98 View commit details
    Browse the repository at this point in the history

  6. fix whitespace contradicts operator precedence 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859594 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    bc66e7a View commit details
    Browse the repository at this point in the history

  7. fix result of multiplication cast to wider type 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859595 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    2922ea2 View commit details
    Browse the repository at this point in the history

  8. fix missing space in string literal (LGTM) 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859596 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    c3e549c View commit details
    Browse the repository at this point in the history

  9. switch svn jars to https site 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859625 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed May 21, 2019
    Copy the full SHA
    06b8886 View commit details
    Browse the repository at this point in the history

  10. try to remove http refs from some pom files 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859663 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed May 21, 2019
    Copy the full SHA
    7604076 View commit details
    Browse the repository at this point in the history

  11. code inspired from Axel Richter on StackOverflow 

    closes #139
closes #144

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859676 13f79535-47bb-0310-9956-ffa450edef68
    @Alain-Bearez
    Alain-Bearez committed May 21, 2019
    Copy the full SHA
    5e070fd View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. try to use more https urls in pom.xml 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859701 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed May 22, 2019
    Copy the full SHA
    897f4a1 View commit details
    Browse the repository at this point in the history

  2. remove some tab indents 

    git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859758 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed May 22, 2019
    Copy the full SHA
    2e01bb3 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. [github-149] improve MAPIMessage.guess7BitEncoding, improve MAPIMessa… 

    …ge.getHtmlBody. Thanks to Dominik Hölzl. This closes #149

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860043 13f79535-47bb-0310-9956-ffa450edef68
    @pjfanning
    pjfanning committed May 26, 2019
    Copy the full SHA
    721180d View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. PropertiesChunk.writeProperties: no need to write ASCII_STRING proper… 

    …ties as UNICODE_STRING as written raw value (PropertyValue.getRawValue) is formatted as ASCII_STRING
    Dominik Hölzl committed May 27, 2019
    Copy the full SHA
    9a1bd08 View commit details
    Browse the repository at this point in the history